diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2008-09-30 14:29:25 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-09-30 16:34:15 -0400 |
commit | eca73214c9c50e290b8dc823b41730b01788872d (patch) | |
tree | 22df16b626afa6fb9755ce289c6efa254f1ae3d4 /arch/arm/mm/mmu.c | |
parent | da46c79a5418dd6ba006665c1535af0713bb77b9 (diff) |
[ARM] mm: move validation of membanks to one place
The newly introduced sanity_check_meminfo() function should be
used to collect all validation of the meminfo array, which we
have in bootmem_init(). Move it there.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mm/mmu.c')
-rw-r--r-- | arch/arm/mm/mmu.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 94d81a2ba008..f03ad87f6baa 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c | |||
@@ -569,9 +569,10 @@ void __init iotable_init(struct map_desc *io_desc, int nr) | |||
569 | static int __init check_membank_valid(struct membank *mb) | 569 | static int __init check_membank_valid(struct membank *mb) |
570 | { | 570 | { |
571 | /* | 571 | /* |
572 | * Check whether this memory region has non-zero size. | 572 | * Check whether this memory region has non-zero size or |
573 | * invalid node number. | ||
573 | */ | 574 | */ |
574 | if (mb->size == 0) | 575 | if (mb->size == 0 || mb->node >= MAX_NUMNODES) |
575 | return 0; | 576 | return 0; |
576 | 577 | ||
577 | /* | 578 | /* |
@@ -605,8 +606,7 @@ static int __init check_membank_valid(struct membank *mb) | |||
605 | 606 | ||
606 | static void __init sanity_check_meminfo(struct meminfo *mi) | 607 | static void __init sanity_check_meminfo(struct meminfo *mi) |
607 | { | 608 | { |
608 | int i; | 609 | int i, j; |
609 | int j; | ||
610 | 610 | ||
611 | for (i = 0, j = 0; i < mi->nr_banks; i++) { | 611 | for (i = 0, j = 0; i < mi->nr_banks; i++) { |
612 | if (check_membank_valid(&mi->bank[i])) | 612 | if (check_membank_valid(&mi->bank[i])) |