aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/mm/dma-mapping.c
diff options
context:
space:
mode:
authorJoonsoo Kim <iamjoonsoo.kim@lge.com>2013-04-04 22:16:14 -0400
committerRussell King <rmk+kernel@arm.linux.org.uk>2013-04-17 11:55:01 -0400
commitdd0f67f4747797f36f0c6bab7fed6a1f2448476d (patch)
tree7da151104d3de9b2848f8e05d1764587760cb6b7 /arch/arm/mm/dma-mapping.c
parentae8a8b9553bd3906af74ff4e8d763904d20ab4e5 (diff)
ARM: 7693/1: mm: clean-up in order to reduce to call kmap_high_get()
In kmap_atomic(), kmap_high_get() is invoked for checking already mapped area. In __flush_dcache_page() and dma_cache_maint_page(), we explicitly call kmap_high_get() before kmap_atomic() when cache_is_vipt(), so kmap_high_get() can be invoked twice. This is useless operation, so remove one. v2: change cache_is_vipt() to cache_is_vipt_nonaliasing() in order to be self-documented Acked-by: Nicolas Pitre <nico@linaro.org> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mm/dma-mapping.c')
-rw-r--r--arch/arm/mm/dma-mapping.c15
1 files changed, 8 insertions, 7 deletions
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index c7e3759f16d3..b47dd48d8634 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -822,16 +822,17 @@ static void dma_cache_maint_page(struct page *page, unsigned long offset,
822 if (PageHighMem(page)) { 822 if (PageHighMem(page)) {
823 if (len + offset > PAGE_SIZE) 823 if (len + offset > PAGE_SIZE)
824 len = PAGE_SIZE - offset; 824 len = PAGE_SIZE - offset;
825 vaddr = kmap_high_get(page); 825
826 if (vaddr) { 826 if (cache_is_vipt_nonaliasing()) {
827 vaddr += offset;
828 op(vaddr, len, dir);
829 kunmap_high(page);
830 } else if (cache_is_vipt()) {
831 /* unmapped pages might still be cached */
832 vaddr = kmap_atomic(page); 827 vaddr = kmap_atomic(page);
833 op(vaddr + offset, len, dir); 828 op(vaddr + offset, len, dir);
834 kunmap_atomic(vaddr); 829 kunmap_atomic(vaddr);
830 } else {
831 vaddr = kmap_high_get(page);
832 if (vaddr) {
833 op(vaddr + offset, len, dir);
834 kunmap_high(page);
835 }
835 } 836 }
836 } else { 837 } else {
837 vaddr = page_address(page) + offset; 838 vaddr = page_address(page) + offset;