diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2008-01-23 09:05:58 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-01-28 08:13:26 -0500 |
commit | 2687bd38573ff6f10d13f60c5c3576cce9cf260d (patch) | |
tree | d05e26158e7c8e9b50fbb7fceca2dac4c91c3996 /arch/arm/mach-pxa/trizeps4.c | |
parent | ca4d6cfcee0cb2d25c0eb3b0172ecc6f223133ef (diff) |
[ARM] pxa: fix mci_init functions returning -1
Fix all those PXA mci_init functions which return -1 rather than
propagating the error code to the higher levels. Remove the silly
set_irq_type() calls as well - use the flags for request_irq()
instead.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-pxa/trizeps4.c')
-rw-r--r-- | arch/arm/mach-pxa/trizeps4.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/arch/arm/mach-pxa/trizeps4.c b/arch/arm/mach-pxa/trizeps4.c index e4ba43bdf85d..853fc9433750 100644 --- a/arch/arm/mach-pxa/trizeps4.c +++ b/arch/arm/mach-pxa/trizeps4.c | |||
@@ -296,11 +296,10 @@ static int trizeps4_mci_init(struct device *dev, irq_handler_t mci_detect_int, v | |||
296 | err = request_irq(TRIZEPS4_MMC_IRQ, mci_detect_int, | 296 | err = request_irq(TRIZEPS4_MMC_IRQ, mci_detect_int, |
297 | IRQF_DISABLED | IRQF_TRIGGER_RISING, | 297 | IRQF_DISABLED | IRQF_TRIGGER_RISING, |
298 | "MMC card detect", data); | 298 | "MMC card detect", data); |
299 | if (err) { | 299 | if (err) |
300 | printk(KERN_ERR "trizeps4_mci_init: MMC/SD: can't request MMC card detect IRQ\n"); | 300 | printk(KERN_ERR "trizeps4_mci_init: MMC/SD: can't request MMC card detect IRQ\n"); |
301 | return -1; | 301 | |
302 | } | 302 | return err; |
303 | return 0; | ||
304 | } | 303 | } |
305 | 304 | ||
306 | static void trizeps4_mci_exit(struct device *dev, void *data) | 305 | static void trizeps4_mci_exit(struct device *dev, void *data) |