diff options
author | Eric Miao <eric.miao@marvell.com> | 2008-09-27 03:49:57 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2008-10-07 14:12:57 -0400 |
commit | 097b53348f34a461d2b07081eae12d823cf3d729 (patch) | |
tree | 62f59bdfc0252346666158b6c236fc250850cb36 /arch/arm/mach-pxa/mainstone.c | |
parent | 52358ba3a89012c54712c24074ceb4b1c669af52 (diff) |
[ARM] ohci-pxa27x: introduce flags to avoid direct access to OHCI registers
Direct access to USB host controller registers is considered to be not
portable, and is usually a bad sign for poorly abstracted interface.
Introduce .flags and .power_on_delay to "struct pxaohci_platform_data"
so that most platforms don't bother to write their own .init/.exit()
sequences.
Signed-off-by: Eric Miao <eric.miao@marvell.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-pxa/mainstone.c')
-rw-r--r-- | arch/arm/mach-pxa/mainstone.c | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/arch/arm/mach-pxa/mainstone.c b/arch/arm/mach-pxa/mainstone.c index d44af761564d..a02edfd4fc0a 100644 --- a/arch/arm/mach-pxa/mainstone.c +++ b/arch/arm/mach-pxa/mainstone.c | |||
@@ -508,19 +508,9 @@ static struct platform_device *platform_devices[] __initdata = { | |||
508 | &mst_gpio_keys_device, | 508 | &mst_gpio_keys_device, |
509 | }; | 509 | }; |
510 | 510 | ||
511 | static int mainstone_ohci_init(struct device *dev) | ||
512 | { | ||
513 | /* Set the Power Control Polarity Low and Power Sense | ||
514 | Polarity Low to active low. */ | ||
515 | UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) & | ||
516 | ~(UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSEP3 | UHCHR_SSE); | ||
517 | |||
518 | return 0; | ||
519 | } | ||
520 | |||
521 | static struct pxaohci_platform_data mainstone_ohci_platform_data = { | 511 | static struct pxaohci_platform_data mainstone_ohci_platform_data = { |
522 | .port_mode = PMM_PERPORT_MODE, | 512 | .port_mode = PMM_PERPORT_MODE, |
523 | .init = mainstone_ohci_init, | 513 | .flags = ENABLE_PORT_ALL | POWER_CONTROL_LOW | POWER_SENSE_LOW, |
524 | }; | 514 | }; |
525 | 515 | ||
526 | #if defined(CONFIG_KEYBOARD_PXA27x) || defined(CONFIG_KEYBOARD_PXA27x_MODULE) | 516 | #if defined(CONFIG_KEYBOARD_PXA27x) || defined(CONFIG_KEYBOARD_PXA27x_MODULE) |