omap: Serial: Define register access modes in LCR

Access to some registers depends on register access mode
Three different modes are available for OMAP (at least)
• Operational mode     LCR_REG[7] = 0x0
• Configuration mode A LCR_REG[7] = 0x1 and LCR_REG[7:0]! = 0xBF
• Configuration mode B LCR_REG[7] = 0x1 and LCR_REG[7:0]  = 0xBF

Define access modes and remove redefinitions and magic numbers
in serial drivers (and later in bluetooth driver).

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
Acked-by: Govindraj.R <govindraj.raja@ti.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Tony Lindgren <tony@atomide.com>

1 files changed, 6 insertions, 6 deletions

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index fa9806250b50..9dc077e2d8af 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -219,7 +219,7 @@ static void omap_uart_save_context(struct omap_uart_state *uart)
                 return;
 
         lcr = serial_read_reg(uart, UART_LCR);
-        serial_write_reg(uart, UART_LCR, 0xBF);
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_B);
         uart->dll = serial_read_reg(uart, UART_DLL);
         uart->dlh = serial_read_reg(uart, UART_DLM);
         serial_write_reg(uart, UART_LCR, lcr);
@@ -227,7 +227,7 @@ static void omap_uart_save_context(struct omap_uart_state *uart)
         uart->sysc = serial_read_reg(uart, UART_OMAP_SYSC);
         uart->scr = serial_read_reg(uart, UART_OMAP_SCR);
         uart->wer = serial_read_reg(uart, UART_OMAP_WER);
-        serial_write_reg(uart, UART_LCR, 0x80);
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_A);
         uart->mcr = serial_read_reg(uart, UART_MCR);
         serial_write_reg(uart, UART_LCR, lcr);
 
@@ -251,19 +251,19 @@ static void omap_uart_restore_context(struct omap_uart_state *uart)
         else
                 serial_write_reg(uart, UART_OMAP_MDR1, UART_OMAP_MDR1_DISABLE);
 
-        serial_write_reg(uart, UART_LCR, 0xBF); /* Config B mode */
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_B);
         efr = serial_read_reg(uart, UART_EFR);
         serial_write_reg(uart, UART_EFR, UART_EFR_ECB);
         serial_write_reg(uart, UART_LCR, 0x0); /* Operational mode */
         serial_write_reg(uart, UART_IER, 0x0);
-        serial_write_reg(uart, UART_LCR, 0xBF); /* Config B mode */
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_B);
         serial_write_reg(uart, UART_DLL, uart->dll);
         serial_write_reg(uart, UART_DLM, uart->dlh);
         serial_write_reg(uart, UART_LCR, 0x0); /* Operational mode */
         serial_write_reg(uart, UART_IER, uart->ier);
-        serial_write_reg(uart, UART_LCR, 0x80);
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_A);
         serial_write_reg(uart, UART_MCR, uart->mcr);
-        serial_write_reg(uart, UART_LCR, 0xBF); /* Config B mode */
+        serial_write_reg(uart, UART_LCR, UART_LCR_CONF_MODE_B);
         serial_write_reg(uart, UART_EFR, efr);
         serial_write_reg(uart, UART_LCR, UART_LCR_WLEN8);
         serial_write_reg(uart, UART_OMAP_SCR, uart->scr);