diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2009-02-22 16:00:55 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-02-23 09:55:34 -0500 |
commit | 7aec53acc0504ab2abd73a6051e7b72f48545ceb (patch) | |
tree | 774135b6260fe17e6140a56167dba6d9e81a745e /arch/arm/mach-omap2/clockdomain.c | |
parent | 7eb1afc9765d07c9036b1ad9e7c03e5bd1a58a2b (diff) |
[ARM] omap: ensure that failing power domain lookups produce errors
Use pr_err() for errors rather than pr_debug(). pr_debug() are
compiled away unless -DDEBUG is used.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-omap2/clockdomain.c')
-rw-r--r-- | arch/arm/mach-omap2/clockdomain.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/arch/arm/mach-omap2/clockdomain.c b/arch/arm/mach-omap2/clockdomain.c index ae0c53abb55a..0e7d501865b6 100644 --- a/arch/arm/mach-omap2/clockdomain.c +++ b/arch/arm/mach-omap2/clockdomain.c | |||
@@ -74,14 +74,11 @@ static void _autodep_lookup(struct clkdm_pwrdm_autodep *autodep) | |||
74 | 74 | ||
75 | pwrdm = pwrdm_lookup(autodep->pwrdm.name); | 75 | pwrdm = pwrdm_lookup(autodep->pwrdm.name); |
76 | if (!pwrdm) { | 76 | if (!pwrdm) { |
77 | pr_debug("clockdomain: _autodep_lookup: powerdomain %s " | 77 | pr_err("clockdomain: autodeps: powerdomain %s does not exist\n", |
78 | "does not exist\n", autodep->pwrdm.name); | 78 | autodep->pwrdm.name); |
79 | WARN_ON(1); | ||
80 | pwrdm = ERR_PTR(-ENOENT); | 79 | pwrdm = ERR_PTR(-ENOENT); |
81 | } | 80 | } |
82 | autodep->pwrdm.ptr = pwrdm; | 81 | autodep->pwrdm.ptr = pwrdm; |
83 | |||
84 | return; | ||
85 | } | 82 | } |
86 | 83 | ||
87 | /* | 84 | /* |
@@ -211,8 +208,8 @@ int clkdm_register(struct clockdomain *clkdm) | |||
211 | 208 | ||
212 | pwrdm = pwrdm_lookup(clkdm->pwrdm.name); | 209 | pwrdm = pwrdm_lookup(clkdm->pwrdm.name); |
213 | if (!pwrdm) { | 210 | if (!pwrdm) { |
214 | pr_debug("clockdomain: clkdm_register %s: powerdomain %s " | 211 | pr_err("clockdomain: %s: powerdomain %s does not exist\n", |
215 | "does not exist\n", clkdm->name, clkdm->pwrdm.name); | 212 | clkdm->name, clkdm->pwrdm.name); |
216 | return -EINVAL; | 213 | return -EINVAL; |
217 | } | 214 | } |
218 | clkdm->pwrdm.ptr = pwrdm; | 215 | clkdm->pwrdm.ptr = pwrdm; |
@@ -222,7 +219,7 @@ int clkdm_register(struct clockdomain *clkdm) | |||
222 | if (_clkdm_lookup(clkdm->name)) { | 219 | if (_clkdm_lookup(clkdm->name)) { |
223 | ret = -EEXIST; | 220 | ret = -EEXIST; |
224 | goto cr_unlock; | 221 | goto cr_unlock; |
225 | }; | 222 | } |
226 | 223 | ||
227 | list_add(&clkdm->node, &clkdm_list); | 224 | list_add(&clkdm->node, &clkdm_list); |
228 | 225 | ||