ARM: OMAP: switch to gpio_direction_output

More conversion to the standard GPIO interfaces:  stop using
omap_set_gpio_direction() entirely, and switch over to the
gpio_direction_output() call.

Note that because gpio_direction_output() includes the initial
value, this change isn't quite transparent.

 - For the call sites which defined an initial value either
   before or after setting the direction, that value was used.

   When that value was previously assigned afterwards, this
   could eliminate a brief output glitch ... and possibly
   change behavior.  In a few cases (LCDs) several values
   were assigned together ... those were re-arranged to match
   the explicit sequence provided.

 - Some call sites didn't define such a value; so I chose an
   initial "off/reset" value that seemed to default to "off".

In short, files touched by this patch might notice some small
changes in startup behavior (with trivial fixes).

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>

1 files changed, 3 insertions, 6 deletions

diff --git a/arch/arm/mach-omap1/board-voiceblue.c b/arch/arm/mach-omap1/board-voiceblue.c
index 86e73b7bffa9..43b008f639f5 100644
--- a/arch/arm/mach-omap1/board-voiceblue.c
+++ b/arch/arm/mach-omap1/board-voiceblue.c
@@ -171,8 +171,7 @@ static void __init voiceblue_init(void)
         omap_request_gpio(0);
         /* smc91x reset */
         omap_request_gpio(7);
-        omap_set_gpio_direction(7, 0);
-        gpio_set_value(7, 1);
+        gpio_direction_output(7, 1);
         udelay(2);      /* wait at least 100ns */
         gpio_set_value(7, 0);
         mdelay(50);     /* 50ms until PHY ready */
@@ -180,8 +179,7 @@ static void __init voiceblue_init(void)
         omap_request_gpio(8);
         /* 16C554 reset*/
         omap_request_gpio(6);
-        omap_set_gpio_direction(6, 0);
-        gpio_set_value(6, 0);
+        gpio_direction_output(6, 0);
         /* 16C554 interrupt pins */
         omap_request_gpio(12);
         omap_request_gpio(13);
@@ -244,8 +242,7 @@ static int wdt_gpio_state;
 
 void voiceblue_wdt_enable(void)
 {
-        omap_set_gpio_direction(0, 0);
-        gpio_set_value(0, 0);
+        gpio_direction_output(0, 0);
         gpio_set_value(0, 1);
         gpio_set_value(0, 0);
         wdt_gpio_state = 0;