aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/mach-mx5
diff options
context:
space:
mode:
authorArnaud Patard (Rtp) <arnaud.patard@rtp-net.org>2011-06-27 16:41:06 -0400
committerSascha Hauer <s.hauer@pengutronix.de>2011-07-26 03:14:53 -0400
commitfbd60a7e87213f702889be21ac14c59fa62defe9 (patch)
tree9d950a506379f19facd15987ca545e58056e7ed7 /arch/arm/mach-mx5
parentf7db3d5f4c27fa93304ead2d7e76d00df3981f02 (diff)
efika: Fix board id detection
Current code is assuming that gpio_get_value() is returning 0 or 1 but it should be checking if the value is 0 or not. Not doing it properly is breaking the detection of the board (and thus the reboot of efika mx to2) when using the new mxc gpio driver, which relies on basic mmio gpio. Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm/mach-mx5')
-rw-r--r--arch/arm/mach-mx5/board-mx51_efikamx.c6
-rw-r--r--arch/arm/mach-mx5/board-mx51_efikasb.c4
2 files changed, 5 insertions, 5 deletions
diff --git a/arch/arm/mach-mx5/board-mx51_efikamx.c b/arch/arm/mach-mx5/board-mx51_efikamx.c
index 6e362315291b..5e8dd6ad6934 100644
--- a/arch/arm/mach-mx5/board-mx51_efikamx.c
+++ b/arch/arm/mach-mx5/board-mx51_efikamx.c
@@ -108,9 +108,9 @@ static void __init mx51_efikamx_board_id(void)
108 gpio_request(EFIKAMX_PCBID2, "pcbid2"); 108 gpio_request(EFIKAMX_PCBID2, "pcbid2");
109 gpio_direction_input(EFIKAMX_PCBID2); 109 gpio_direction_input(EFIKAMX_PCBID2);
110 110
111 id = gpio_get_value(EFIKAMX_PCBID0); 111 id = gpio_get_value(EFIKAMX_PCBID0) ? 1 : 0;
112 id |= gpio_get_value(EFIKAMX_PCBID1) << 1; 112 id |= (gpio_get_value(EFIKAMX_PCBID1) ? 1 : 0) << 1;
113 id |= gpio_get_value(EFIKAMX_PCBID2) << 2; 113 id |= (gpio_get_value(EFIKAMX_PCBID2) ? 1 : 0) << 2;
114 114
115 switch (id) { 115 switch (id) {
116 case 7: 116 case 7:
diff --git a/arch/arm/mach-mx5/board-mx51_efikasb.c b/arch/arm/mach-mx5/board-mx51_efikasb.c
index 8054f3f7f491..f0c33b39d3e7 100644
--- a/arch/arm/mach-mx5/board-mx51_efikasb.c
+++ b/arch/arm/mach-mx5/board-mx51_efikasb.c
@@ -232,8 +232,8 @@ static void __init mx51_efikasb_board_id(void)
232 gpio_request(EFIKASB_PCBID1, "pcb id1"); 232 gpio_request(EFIKASB_PCBID1, "pcb id1");
233 gpio_direction_input(EFIKASB_PCBID1); 233 gpio_direction_input(EFIKASB_PCBID1);
234 234
235 id = gpio_get_value(EFIKASB_PCBID0); 235 id = gpio_get_value(EFIKASB_PCBID0) ? 1 : 0;
236 id |= gpio_get_value(EFIKASB_PCBID1) << 1; 236 id |= (gpio_get_value(EFIKASB_PCBID1) ? 1 : 0) << 1;
237 237
238 switch (id) { 238 switch (id) {
239 default: 239 default: