iMX51: introduce IMX_GPIO_NR

Currently, to define a GPIO number, we're using something like :

#define EFIKAMX_PCBID0         (2*32 + 16)

to define GPIO 3 16.

This is not really readable and it's error prone imho (note the 3 vs 2).
So, I'm introducing a new macro to define this in a better way. Now, the
code sample become :

#define EFIKAMX_PCBID0         IMX_GPIO_NR(3, 16)

v2:
- move to gpio.h
- add parens & spaces
- switch to IMX_GPIO_NR instead of MX51_GPIO_NR

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Eric Bénard <eric@eukrea.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

1 files changed, 14 insertions, 14 deletions

diff --git a/arch/arm/mach-mx5/board-cpuimx51sd.c b/arch/arm/mach-mx5/board-cpuimx51sd.c
index ff1f45e96c32..8e71c19b9019 100644
--- a/arch/arm/mach-mx5/board-cpuimx51sd.c
+++ b/arch/arm/mach-mx5/board-cpuimx51sd.c
@@ -43,19 +43,19 @@
 #include "devices-imx51.h"
 #include "devices.h"
 
-#define USBH1_RST               (1*32 + 28)
-#define ETH_RST                 (1*32 + 31)
-#define TSC2007_IRQGPIO         (2*32 + 12)
-#define CAN_IRQGPIO             (0*32 + 1)
-#define CAN_RST                 (3*32 + 15)
-#define CAN_NCS                 (3*32 + 24)
-#define CAN_RXOBF               (0*32 + 4)
-#define CAN_RX1BF               (0*32 + 6)
-#define CAN_TXORTS              (0*32 + 7)
-#define CAN_TX1RTS              (0*32 + 8)
-#define CAN_TX2RTS              (0*32 + 9)
-#define I2C_SCL                 (3*32 + 16)
-#define I2C_SDA                 (3*32 + 17)
+#define USBH1_RST               IMX_GPIO_NR(2, 28)
+#define ETH_RST                 IMX_GPIO_NR(2, 31)
+#define TSC2007_IRQGPIO         IMX_GPIO_NR(3, 12)
+#define CAN_IRQGPIO             IMX_GPIO_NR(1, 1)
+#define CAN_RST                 IMX_GPIO_NR(4, 15)
+#define CAN_NCS                 IMX_GPIO_NR(4, 24)
+#define CAN_RXOBF               IMX_GPIO_NR(1, 4)
+#define CAN_RX1BF               IMX_GPIO_NR(1, 6)
+#define CAN_TXORTS              IMX_GPIO_NR(1, 7)
+#define CAN_TX1RTS              IMX_GPIO_NR(1, 8)
+#define CAN_TX2RTS              IMX_GPIO_NR(1, 9)
+#define I2C_SCL                 IMX_GPIO_NR(4, 16)
+#define I2C_SDA                 IMX_GPIO_NR(4, 17)
 
 /* USB_CTRL_1 */
 #define MX51_USB_CTRL_1_OFFSET          0x10
@@ -243,7 +243,7 @@ static struct spi_board_info cpuimx51sd_spi_device[] = {
                 .mode           = SPI_MODE_0,
                 .chip_select     = 0,
                 .platform_data   = &mcp251x_info,
-                .irq             = gpio_to_irq(0 * 32 + 1)
+                .irq             = gpio_to_irq(CAN_IRQGPIO)
         },
 };