diff options
author | Dan Williams <dan.j.williams@intel.com> | 2007-05-14 20:03:36 -0400 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2007-05-16 10:35:27 -0400 |
commit | d73d8011779292788def2cd2520d6f39d9b406de (patch) | |
tree | 4a74fca4a1e549091414a0a0cbbc2cf63fcbd64e /arch/arm/mach-iop33x | |
parent | e702a7155d14a6e11645e17d829217ae98fd45bb (diff) |
[ARM] 4383/1: iop: fix usage of '__init' and 'inline' in iop files
WARNING: arch/arm/mach-iop13xx/built-in.o - Section mismatch: reference to
.init.text:iop13xx_pcie_map_irq from .text between 'iop13xx_pci_setup' (at
offset 0x7fc) and 'iop13xx_map_pci_memory'
While fixing this warning I also recalled Adrian Bunk's recommendation to
not use inline in .c files, as 'iop13xx_map_pci_memory' is needlessly
inlined.
Removing 'inline' uncovered some dead code so that is cleaned up as well.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/mach-iop33x')
-rw-r--r-- | arch/arm/mach-iop33x/iq80331.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-iop33x/iq80332.c | 2 | ||||
-rw-r--r-- | arch/arm/mach-iop33x/irq.c | 12 |
3 files changed, 8 insertions, 8 deletions
diff --git a/arch/arm/mach-iop33x/iq80331.c b/arch/arm/mach-iop33x/iq80331.c index 376c932830be..2b063180687a 100644 --- a/arch/arm/mach-iop33x/iq80331.c +++ b/arch/arm/mach-iop33x/iq80331.c | |||
@@ -55,7 +55,7 @@ static struct sys_timer iq80331_timer = { | |||
55 | /* | 55 | /* |
56 | * IQ80331 PCI. | 56 | * IQ80331 PCI. |
57 | */ | 57 | */ |
58 | static inline int __init | 58 | static int __init |
59 | iq80331_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin) | 59 | iq80331_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin) |
60 | { | 60 | { |
61 | int irq; | 61 | int irq; |
diff --git a/arch/arm/mach-iop33x/iq80332.c b/arch/arm/mach-iop33x/iq80332.c index 58c81496c6f6..7889ce3cb08e 100644 --- a/arch/arm/mach-iop33x/iq80332.c +++ b/arch/arm/mach-iop33x/iq80332.c | |||
@@ -55,7 +55,7 @@ static struct sys_timer iq80332_timer = { | |||
55 | /* | 55 | /* |
56 | * IQ80332 PCI. | 56 | * IQ80332 PCI. |
57 | */ | 57 | */ |
58 | static inline int __init | 58 | static int __init |
59 | iq80332_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin) | 59 | iq80332_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin) |
60 | { | 60 | { |
61 | int irq; | 61 | int irq; |
diff --git a/arch/arm/mach-iop33x/irq.c b/arch/arm/mach-iop33x/irq.c index c65ea78a2427..f09dd054b9c0 100644 --- a/arch/arm/mach-iop33x/irq.c +++ b/arch/arm/mach-iop33x/irq.c | |||
@@ -22,32 +22,32 @@ | |||
22 | static u32 iop33x_mask0; | 22 | static u32 iop33x_mask0; |
23 | static u32 iop33x_mask1; | 23 | static u32 iop33x_mask1; |
24 | 24 | ||
25 | static inline void intctl0_write(u32 val) | 25 | static void intctl0_write(u32 val) |
26 | { | 26 | { |
27 | asm volatile("mcr p6, 0, %0, c0, c0, 0" : : "r" (val)); | 27 | asm volatile("mcr p6, 0, %0, c0, c0, 0" : : "r" (val)); |
28 | } | 28 | } |
29 | 29 | ||
30 | static inline void intctl1_write(u32 val) | 30 | static void intctl1_write(u32 val) |
31 | { | 31 | { |
32 | asm volatile("mcr p6, 0, %0, c1, c0, 0" : : "r" (val)); | 32 | asm volatile("mcr p6, 0, %0, c1, c0, 0" : : "r" (val)); |
33 | } | 33 | } |
34 | 34 | ||
35 | static inline void intstr0_write(u32 val) | 35 | static void intstr0_write(u32 val) |
36 | { | 36 | { |
37 | asm volatile("mcr p6, 0, %0, c2, c0, 0" : : "r" (val)); | 37 | asm volatile("mcr p6, 0, %0, c2, c0, 0" : : "r" (val)); |
38 | } | 38 | } |
39 | 39 | ||
40 | static inline void intstr1_write(u32 val) | 40 | static void intstr1_write(u32 val) |
41 | { | 41 | { |
42 | asm volatile("mcr p6, 0, %0, c3, c0, 0" : : "r" (val)); | 42 | asm volatile("mcr p6, 0, %0, c3, c0, 0" : : "r" (val)); |
43 | } | 43 | } |
44 | 44 | ||
45 | static inline void intbase_write(u32 val) | 45 | static void intbase_write(u32 val) |
46 | { | 46 | { |
47 | asm volatile("mcr p6, 0, %0, c12, c0, 0" : : "r" (val)); | 47 | asm volatile("mcr p6, 0, %0, c12, c0, 0" : : "r" (val)); |
48 | } | 48 | } |
49 | 49 | ||
50 | static inline void intsize_write(u32 val) | 50 | static void intsize_write(u32 val) |
51 | { | 51 | { |
52 | asm volatile("mcr p6, 0, %0, c13, c0, 0" : : "r" (val)); | 52 | asm volatile("mcr p6, 0, %0, c13, c0, 0" : : "r" (val)); |
53 | } | 53 | } |