diff options
author | Benoît Thébaudeau <benoit.thebaudeau@advansee.com> | 2012-06-12 13:46:43 -0400 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2012-06-13 03:03:24 -0400 |
commit | 33a264ddcded2120fc0baa7afe4bcc5b4df3c416 (patch) | |
tree | dc04c6e89f00a27b4dd213cd322b034b4d96462f /arch/arm/mach-imx/mach-pcm043.c | |
parent | cfaf025112d3856637ff34a767ef785ef5cf2ca9 (diff) |
ARM: imx: cleanup otg_mode
Cleanup the code for the otg_mode command line param:
* Use the bool type as it applies here.
* Qualify otg_mode_host with __initdata since this variable is only used in this
context.
* The __setup functions are not supposed to return a status code, but a boolean
indicating whether the param has been handled. See obsolete_checksetup() in
init/main.c.
Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm/mach-imx/mach-pcm043.c')
-rw-r--r-- | arch/arm/mach-imx/mach-pcm043.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mach-imx/mach-pcm043.c b/arch/arm/mach-imx/mach-pcm043.c index 73585f55cca0..a8f4a0087b8c 100644 --- a/arch/arm/mach-imx/mach-pcm043.c +++ b/arch/arm/mach-imx/mach-pcm043.c | |||
@@ -330,18 +330,18 @@ static const struct fsl_usb2_platform_data otg_device_pdata __initconst = { | |||
330 | .phy_mode = FSL_USB2_PHY_UTMI, | 330 | .phy_mode = FSL_USB2_PHY_UTMI, |
331 | }; | 331 | }; |
332 | 332 | ||
333 | static int otg_mode_host; | 333 | static bool otg_mode_host __initdata; |
334 | 334 | ||
335 | static int __init pcm043_otg_mode(char *options) | 335 | static int __init pcm043_otg_mode(char *options) |
336 | { | 336 | { |
337 | if (!strcmp(options, "host")) | 337 | if (!strcmp(options, "host")) |
338 | otg_mode_host = 1; | 338 | otg_mode_host = true; |
339 | else if (!strcmp(options, "device")) | 339 | else if (!strcmp(options, "device")) |
340 | otg_mode_host = 0; | 340 | otg_mode_host = false; |
341 | else | 341 | else |
342 | pr_info("otg_mode neither \"host\" nor \"device\". " | 342 | pr_info("otg_mode neither \"host\" nor \"device\". " |
343 | "Defaulting to device\n"); | 343 | "Defaulting to device\n"); |
344 | return 0; | 344 | return 1; |
345 | } | 345 | } |
346 | __setup("otg_mode=", pcm043_otg_mode); | 346 | __setup("otg_mode=", pcm043_otg_mode); |
347 | 347 | ||