aboutsummaryrefslogtreecommitdiffstats
path: root/arch/arm/kernel/smp.c
diff options
context:
space:
mode:
authorRussell King <rmk+kernel@arm.linux.org.uk>2010-07-26 08:31:27 -0400
committerRussell King <rmk+kernel@arm.linux.org.uk>2010-07-27 05:48:43 -0400
commit3d3f78d752bfada5b6041f2f7bd0833d8bdf7a4a (patch)
tree14365f6ef64f10095c3080cdabb9b8cd0a51d671 /arch/arm/kernel/smp.c
parent5388a6b266e9c3357353332ba0cd5549082887f1 (diff)
ARM: call machine_shutdown() from machine_halt(), etc
x86 calls machine_shutdown() from the various machine_*() calls which take the machine down ready for halting, restarting, etc, and uses this to bring the system safely to a point where those actions can be performed. Such actions are stopping the secondary CPUs. So, change the ARM implementation of these to reflect what x86 does. This solves kexec problems on ARM SMP platforms, where the secondary CPUs were left running across the kexec call. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/kernel/smp.c')
-rw-r--r--arch/arm/kernel/smp.c11
1 files changed, 7 insertions, 4 deletions
diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
index 0170e248a1dd..40dc74f2b27f 100644
--- a/arch/arm/kernel/smp.c
+++ b/arch/arm/kernel/smp.c
@@ -471,10 +471,13 @@ static DEFINE_SPINLOCK(stop_lock);
471 */ 471 */
472static void ipi_cpu_stop(unsigned int cpu) 472static void ipi_cpu_stop(unsigned int cpu)
473{ 473{
474 spin_lock(&stop_lock); 474 if (system_state == SYSTEM_BOOTING ||
475 printk(KERN_CRIT "CPU%u: stopping\n", cpu); 475 system_state == SYSTEM_RUNNING) {
476 dump_stack(); 476 spin_lock(&stop_lock);
477 spin_unlock(&stop_lock); 477 printk(KERN_CRIT "CPU%u: stopping\n", cpu);
478 dump_stack();
479 spin_unlock(&stop_lock);
480 }
478 481
479 set_cpu_online(cpu, false); 482 set_cpu_online(cpu, false);
480 483