diff options
author | Will Deacon <will.deacon@arm.com> | 2010-11-30 12:15:53 -0500 |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2010-12-04 06:17:44 -0500 |
commit | 4d6b7a779be34e1df296abc1dc555134a8cf34af (patch) | |
tree | 928b2459936859a87aaa2af46d521059cffca570 /arch/arm/kernel/perf_event_v7.c | |
parent | 83cf1eecfe9afee99d6b86f963187acd414c019d (diff) |
ARM: 6512/1: perf: fix warnings generated by sparse
Russell reported a number of warnings coming from sparse when
checking the ARM perf_event.c files:
| perf_event.c seems to also have problems too:
|
| CHECK arch/arm/kernel/perf_event.c
| arch/arm/kernel/perf_event.c:37:1: warning: symbol 'pmu_lock' was not declared. Should it be static?
| arch/arm/kernel/perf_event.c:70:1: warning: symbol 'cpu_hw_events' was not declared. Should it be static?
| arch/arm/kernel/perf_event.c:1006:1: warning: symbol 'armv6pmu_enable_event' was not declared. Should it be static?
| arch/arm/kernel/perf_event.c:1113:1: warning: symbol 'armv6pmu_stop' was not declared. Should it be static?
| arch/arm/kernel/perf_event.c:1956:6: warning: symbol 'armv7pmu_enable_event' was not declared. Should it be static?
| arch/arm/kernel/perf_event.c:3072:14: warning: incorrect type in argument 1 (different address spaces)
| arch/arm/kernel/perf_event.c:3072:14: expected void const volatile [noderef] <asn:1>*<noident>
| arch/arm/kernel/perf_event.c:3072:14: got struct frame_tail *tail
| arch/arm/kernel/perf_event.c:3074:49: warning: incorrect type in argument 2 (different address spaces)
| arch/arm/kernel/perf_event.c:3074:49: expected void const [noderef] <asn:1>*from
| arch/arm/kernel/perf_event.c:3074:49: got struct frame_tail *tail
This patch resolves these issues so we can live in silence
again.
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'arch/arm/kernel/perf_event_v7.c')
-rw-r--r-- | arch/arm/kernel/perf_event_v7.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c index 4d0423969df9..a68ff1c10dec 100644 --- a/arch/arm/kernel/perf_event_v7.c +++ b/arch/arm/kernel/perf_event_v7.c | |||
@@ -681,7 +681,7 @@ static void armv7_pmnc_dump_regs(void) | |||
681 | } | 681 | } |
682 | #endif | 682 | #endif |
683 | 683 | ||
684 | void armv7pmu_enable_event(struct hw_perf_event *hwc, int idx) | 684 | static void armv7pmu_enable_event(struct hw_perf_event *hwc, int idx) |
685 | { | 685 | { |
686 | unsigned long flags; | 686 | unsigned long flags; |
687 | 687 | ||
@@ -874,7 +874,7 @@ static u32 __init armv7_reset_read_pmnc(void) | |||
874 | return nb_cnt + 1; | 874 | return nb_cnt + 1; |
875 | } | 875 | } |
876 | 876 | ||
877 | const struct arm_pmu *__init armv7_a8_pmu_init(void) | 877 | static const struct arm_pmu *__init armv7_a8_pmu_init(void) |
878 | { | 878 | { |
879 | armv7pmu.id = ARM_PERF_PMU_ID_CA8; | 879 | armv7pmu.id = ARM_PERF_PMU_ID_CA8; |
880 | armv7pmu.name = "ARMv7 Cortex-A8"; | 880 | armv7pmu.name = "ARMv7 Cortex-A8"; |
@@ -884,7 +884,7 @@ const struct arm_pmu *__init armv7_a8_pmu_init(void) | |||
884 | return &armv7pmu; | 884 | return &armv7pmu; |
885 | } | 885 | } |
886 | 886 | ||
887 | const struct arm_pmu *__init armv7_a9_pmu_init(void) | 887 | static const struct arm_pmu *__init armv7_a9_pmu_init(void) |
888 | { | 888 | { |
889 | armv7pmu.id = ARM_PERF_PMU_ID_CA9; | 889 | armv7pmu.id = ARM_PERF_PMU_ID_CA9; |
890 | armv7pmu.name = "ARMv7 Cortex-A9"; | 890 | armv7pmu.name = "ARMv7 Cortex-A9"; |
@@ -894,12 +894,12 @@ const struct arm_pmu *__init armv7_a9_pmu_init(void) | |||
894 | return &armv7pmu; | 894 | return &armv7pmu; |
895 | } | 895 | } |
896 | #else | 896 | #else |
897 | const struct arm_pmu *__init armv7_a8_pmu_init(void) | 897 | static const struct arm_pmu *__init armv7_a8_pmu_init(void) |
898 | { | 898 | { |
899 | return NULL; | 899 | return NULL; |
900 | } | 900 | } |
901 | 901 | ||
902 | const struct arm_pmu *__init armv7_a9_pmu_init(void) | 902 | static const struct arm_pmu *__init armv7_a9_pmu_init(void) |
903 | { | 903 | { |
904 | return NULL; | 904 | return NULL; |
905 | } | 905 | } |