diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2012-04-28 17:51:42 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-05-21 14:38:24 -0400 |
commit | 21c1176a72bd019d513b26e05d491a31b50b18d2 (patch) | |
tree | f4b17999ea482335f50c2b7e5c2f8f5e9636fcba /arch/arm/kernel/entry-common.S | |
parent | d9be5ea6f9b6a51535ccdd9881ffb3be2dbd48e9 (diff) |
arm: if we get into work_pending while returning to kernel mode, just go away
checking in do_signal() is pointless - if we get there with !user_mode(regs)
(and we might), we'll end up looping indefinitely. Check in work_pending
and break out of the loop if so.
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'arch/arm/kernel/entry-common.S')
-rw-r--r-- | arch/arm/kernel/entry-common.S | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/arch/arm/kernel/entry-common.S b/arch/arm/kernel/entry-common.S index 82aaf0aeb85d..b669b49d7cc4 100644 --- a/arch/arm/kernel/entry-common.S +++ b/arch/arm/kernel/entry-common.S | |||
@@ -56,7 +56,10 @@ work_pending: | |||
56 | /* | 56 | /* |
57 | * TIF_SIGPENDING or TIF_NOTIFY_RESUME must've been set if we got here | 57 | * TIF_SIGPENDING or TIF_NOTIFY_RESUME must've been set if we got here |
58 | */ | 58 | */ |
59 | ldr r2, [sp, #S_PSR] | ||
59 | mov r0, sp @ 'regs' | 60 | mov r0, sp @ 'regs' |
61 | tst r2, #15 @ are we returning to user mode? | ||
62 | bne no_work_pending @ no? just leave, then... | ||
60 | mov r2, why @ 'syscall' | 63 | mov r2, why @ 'syscall' |
61 | tst r1, #_TIF_SIGPENDING @ delivering a signal? | 64 | tst r1, #_TIF_SIGPENDING @ delivering a signal? |
62 | movne why, #0 @ prevent further restarts | 65 | movne why, #0 @ prevent further restarts |