[PATCH] DRIVER MODEL: Get rid of the obsolete tri-level suspend/resume callbacks

In PM v1, all devices were called at SUSPEND_DISABLE level.  Then
all devices were called at SUSPEND_SAVE_STATE level, and finally
SUSPEND_POWER_DOWN level.  However, with PM v2, to maintain
compatibility for platform devices, I arranged for the PM v2
suspend/resume callbacks to call the old PM v1 suspend/resume
callbacks three times with each level in order so that existing
drivers continued to work.

Since this is obsolete infrastructure which is no longer necessary,
we can remove it.  Here's an (untested) patch to do exactly that.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 11 insertions, 13 deletions

diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c
index 9e5245c702de..e8356b76d7c6 100644
--- a/arch/arm/common/scoop.c
+++ b/arch/arm/common/scoop.c
@@ -102,26 +102,24 @@ static void check_scoop_reg(struct scoop_dev *sdev)
 }
 
 #ifdef CONFIG_PM
-static int scoop_suspend(struct device *dev, pm_message_t state, uint32_t level)
+static int scoop_suspend(struct device *dev, pm_message_t state)
 {
-        if (level == SUSPEND_POWER_DOWN) {
-                struct scoop_dev *sdev = dev_get_drvdata(dev);
+        struct scoop_dev *sdev = dev_get_drvdata(dev);
+
+        check_scoop_reg(sdev);
+        sdev->scoop_gpwr = SCOOP_REG(sdev->base, SCOOP_GPWR);
+        SCOOP_REG(sdev->base, SCOOP_GPWR) = (sdev->scoop_gpwr & ~sdev->suspend_clr) | sdev->suspend_set;
 
-                check_scoop_reg(sdev);
-                sdev->scoop_gpwr = SCOOP_REG(sdev->base, SCOOP_GPWR);
-                SCOOP_REG(sdev->base, SCOOP_GPWR) = (sdev->scoop_gpwr & ~sdev->suspend_clr) | sdev->suspend_set;
-        }
         return 0;
 }
 
-static int scoop_resume(struct device *dev, uint32_t level)
+static int scoop_resume(struct device *dev)
 {
-        if (level == RESUME_POWER_ON) {
-                struct scoop_dev *sdev = dev_get_drvdata(dev);
+        struct scoop_dev *sdev = dev_get_drvdata(dev);
+
+        check_scoop_reg(sdev);
+        SCOOP_REG(sdev->base,SCOOP_GPWR) = sdev->scoop_gpwr;
 
-                check_scoop_reg(sdev);
-                SCOOP_REG(sdev->base,SCOOP_GPWR) = sdev->scoop_gpwr;
-        }
         return 0;
 }
 #else