diff options
author | Pavel Machek <pavel@suse.cz> | 2006-09-29 05:01:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 12:18:23 -0400 |
commit | 8e9cb8fdab0709c508cd9689bee6916a270191cc (patch) | |
tree | b7471650ba29b342c2cae805187534b6969d1283 /Documentation | |
parent | 1497b2749babb01458a6d9dfd4dfb493b3d388f2 (diff) |
[PATCH] SubmittingPatches cleanups
This cleans up SubmittingPatches a bit.
Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'Documentation')
-rw-r--r-- | Documentation/SubmittingPatches | 26 |
1 files changed, 13 insertions, 13 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index d42ab4c9e893..958182f6aa1f 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches | |||
@@ -173,15 +173,15 @@ For small patches you may want to CC the Trivial Patch Monkey | |||
173 | trivial@kernel.org managed by Adrian Bunk; which collects "trivial" | 173 | trivial@kernel.org managed by Adrian Bunk; which collects "trivial" |
174 | patches. Trivial patches must qualify for one of the following rules: | 174 | patches. Trivial patches must qualify for one of the following rules: |
175 | Spelling fixes in documentation | 175 | Spelling fixes in documentation |
176 | Spelling fixes which could break grep(1). | 176 | Spelling fixes which could break grep(1) |
177 | Warning fixes (cluttering with useless warnings is bad) | 177 | Warning fixes (cluttering with useless warnings is bad) |
178 | Compilation fixes (only if they are actually correct) | 178 | Compilation fixes (only if they are actually correct) |
179 | Runtime fixes (only if they actually fix things) | 179 | Runtime fixes (only if they actually fix things) |
180 | Removing use of deprecated functions/macros (eg. check_region). | 180 | Removing use of deprecated functions/macros (eg. check_region) |
181 | Contact detail and documentation fixes | 181 | Contact detail and documentation fixes |
182 | Non-portable code replaced by portable code (even in arch-specific, | 182 | Non-portable code replaced by portable code (even in arch-specific, |
183 | since people copy, as long as it's trivial) | 183 | since people copy, as long as it's trivial) |
184 | Any fix by the author/maintainer of the file. (ie. patch monkey | 184 | Any fix by the author/maintainer of the file (ie. patch monkey |
185 | in re-transmission mode) | 185 | in re-transmission mode) |
186 | URL: <http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/> | 186 | URL: <http://www.kernel.org/pub/linux/kernel/people/bunk/trivial/> |
187 | 187 | ||
@@ -245,13 +245,13 @@ updated change. | |||
245 | It is quite common for Linus to "drop" your patch without comment. | 245 | It is quite common for Linus to "drop" your patch without comment. |
246 | That's the nature of the system. If he drops your patch, it could be | 246 | That's the nature of the system. If he drops your patch, it could be |
247 | due to | 247 | due to |
248 | * Your patch did not apply cleanly to the latest kernel version | 248 | * Your patch did not apply cleanly to the latest kernel version. |
249 | * Your patch was not sufficiently discussed on linux-kernel. | 249 | * Your patch was not sufficiently discussed on linux-kernel. |
250 | * A style issue (see section 2), | 250 | * A style issue (see section 2). |
251 | * An e-mail formatting issue (re-read this section) | 251 | * An e-mail formatting issue (re-read this section). |
252 | * A technical problem with your change | 252 | * A technical problem with your change. |
253 | * He gets tons of e-mail, and yours got lost in the shuffle | 253 | * He gets tons of e-mail, and yours got lost in the shuffle. |
254 | * You are being annoying (See Figure 1) | 254 | * You are being annoying. |
255 | 255 | ||
256 | When in doubt, solicit comments on linux-kernel mailing list. | 256 | When in doubt, solicit comments on linux-kernel mailing list. |
257 | 257 | ||
@@ -476,10 +476,10 @@ SECTION 3 - REFERENCES | |||
476 | Andrew Morton, "The perfect patch" (tpp). | 476 | Andrew Morton, "The perfect patch" (tpp). |
477 | <http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt> | 477 | <http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt> |
478 | 478 | ||
479 | Jeff Garzik, "Linux kernel patch submission format." | 479 | Jeff Garzik, "Linux kernel patch submission format". |
480 | <http://linux.yyz.us/patch-format.html> | 480 | <http://linux.yyz.us/patch-format.html> |
481 | 481 | ||
482 | Greg Kroah-Hartman "How to piss off a kernel subsystem maintainer". | 482 | Greg Kroah-Hartman, "How to piss off a kernel subsystem maintainer". |
483 | <http://www.kroah.com/log/2005/03/31/> | 483 | <http://www.kroah.com/log/2005/03/31/> |
484 | <http://www.kroah.com/log/2005/07/08/> | 484 | <http://www.kroah.com/log/2005/07/08/> |
485 | <http://www.kroah.com/log/2005/10/19/> | 485 | <http://www.kroah.com/log/2005/10/19/> |
@@ -488,9 +488,9 @@ Greg Kroah-Hartman "How to piss off a kernel subsystem maintainer". | |||
488 | NO!!!! No more huge patch bombs to linux-kernel@vger.kernel.org people! | 488 | NO!!!! No more huge patch bombs to linux-kernel@vger.kernel.org people! |
489 | <http://marc.theaimsgroup.com/?l=linux-kernel&m=112112749912944&w=2> | 489 | <http://marc.theaimsgroup.com/?l=linux-kernel&m=112112749912944&w=2> |
490 | 490 | ||
491 | Kernel Documentation/CodingStyle | 491 | Kernel Documentation/CodingStyle: |
492 | <http://sosdg.org/~coywolf/lxr/source/Documentation/CodingStyle> | 492 | <http://sosdg.org/~coywolf/lxr/source/Documentation/CodingStyle> |
493 | 493 | ||
494 | Linus Torvald's mail on the canonical patch format: | 494 | Linus Torvalds's mail on the canonical patch format: |
495 | <http://lkml.org/lkml/2005/4/7/183> | 495 | <http://lkml.org/lkml/2005/4/7/183> |
496 | -- | 496 | -- |