diff options
| author | Javier Martinez Canillas <javier.martinez@collabora.co.uk> | 2013-03-15 09:31:57 -0400 |
|---|---|---|
| committer | Benoit Cousson <benoit.cousson@linaro.org> | 2013-04-08 18:21:23 -0400 |
| commit | 5dad5ec540089dd2b100b0e7e91df7a7437ae2d3 (patch) | |
| tree | f336b5c31185c75f7df73baba98ee42860ffb2c0 /Documentation | |
| parent | 97597b962529fef9c6976bab57f25ef5ce5e7383 (diff) | |
Documentation: dt: gpio-omap: Move interrupt-controller from #interrupt-cells description
The binding documentation for the OMAP GPIO controller has the
"#interrupt-cells" property listed before "#interrupt-controller"
property but its description after.
This is confusing so we move "#interrupt-cells" after the
"interrupt-controller" property so is followed by its description.
While being there, change the properties order to be consistent with
Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
and Documentation/devicetree/bindings/gpio/gpio.txt.
According with these docs, the order of the properties for a gpio-omap
device node should be:
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
Reported-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Acked-by: Jon Hunter <jon-hunter@ti.com>
Signed-off-by: Benoit Cousson <benoit.cousson@linaro.org>
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/devicetree/bindings/gpio/gpio-omap.txt | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/Documentation/devicetree/bindings/gpio/gpio-omap.txt b/Documentation/devicetree/bindings/gpio/gpio-omap.txt index bff51a2fee1e..a56e3a53a360 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-omap.txt +++ b/Documentation/devicetree/bindings/gpio/gpio-omap.txt | |||
| @@ -5,12 +5,12 @@ Required properties: | |||
| 5 | - "ti,omap2-gpio" for OMAP2 controllers | 5 | - "ti,omap2-gpio" for OMAP2 controllers |
| 6 | - "ti,omap3-gpio" for OMAP3 controllers | 6 | - "ti,omap3-gpio" for OMAP3 controllers |
| 7 | - "ti,omap4-gpio" for OMAP4 controllers | 7 | - "ti,omap4-gpio" for OMAP4 controllers |
| 8 | - gpio-controller : Marks the device node as a GPIO controller. | ||
| 8 | - #gpio-cells : Should be two. | 9 | - #gpio-cells : Should be two. |
| 9 | - first cell is the pin number | 10 | - first cell is the pin number |
| 10 | - second cell is used to specify optional parameters (unused) | 11 | - second cell is used to specify optional parameters (unused) |
| 11 | - gpio-controller : Marks the device node as a GPIO controller. | 12 | - interrupt-controller: Mark the device node as an interrupt controller. |
| 12 | - #interrupt-cells : Should be 2. | 13 | - #interrupt-cells : Should be 2. |
| 13 | - interrupt-controller: Mark the device node as an interrupt controller | ||
| 14 | The first cell is the GPIO number. | 14 | The first cell is the GPIO number. |
| 15 | The second cell is used to specify flags: | 15 | The second cell is used to specify flags: |
| 16 | bits[3:0] trigger type and level flags: | 16 | bits[3:0] trigger type and level flags: |
| @@ -29,8 +29,8 @@ Example: | |||
| 29 | gpio4: gpio4 { | 29 | gpio4: gpio4 { |
| 30 | compatible = "ti,omap4-gpio"; | 30 | compatible = "ti,omap4-gpio"; |
| 31 | ti,hwmods = "gpio4"; | 31 | ti,hwmods = "gpio4"; |
| 32 | #gpio-cells = <2>; | ||
| 33 | gpio-controller; | 32 | gpio-controller; |
| 34 | #interrupt-cells = <2>; | 33 | #gpio-cells = <2>; |
| 35 | interrupt-controller; | 34 | interrupt-controller; |
| 35 | #interrupt-cells = <2>; | ||
| 36 | }; | 36 | }; |