diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2015-04-03 15:41:18 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2015-04-11 22:29:40 -0400 |
commit | 5d5d568975307877e9195f5305f4240e506a2807 (patch) | |
tree | b58d5b1af9e77189357b95f5cb0dc635bba65285 /Documentation | |
parent | 86cc05840a0da1afcb6b8151b53f3b606457c91b (diff) |
make new_sync_{read,write}() static
All places outside of core VFS that checked ->read and ->write for being NULL or
called the methods directly are gone now, so NULL {read,write} with non-NULL
{read,write}_iter will do the right thing in all cases.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'Documentation')
-rw-r--r-- | Documentation/filesystems/porting | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/Documentation/filesystems/porting b/Documentation/filesystems/porting index fa2db081505e..4006483c275f 100644 --- a/Documentation/filesystems/porting +++ b/Documentation/filesystems/porting | |||
@@ -471,3 +471,12 @@ in your dentry operations instead. | |||
471 | [mandatory] | 471 | [mandatory] |
472 | f_dentry is gone; use f_path.dentry, or, better yet, see if you can avoid | 472 | f_dentry is gone; use f_path.dentry, or, better yet, see if you can avoid |
473 | it entirely. | 473 | it entirely. |
474 | -- | ||
475 | [mandatory] | ||
476 | never call ->read() and ->write() directly; use __vfs_{read,write} or | ||
477 | wrappers; instead of checking for ->write or ->read being NULL, look for | ||
478 | FMODE_CAN_{WRITE,READ} in file->f_mode. | ||
479 | -- | ||
480 | [mandatory] | ||
481 | do _not_ use new_sync_{read,write} for ->read/->write; leave it NULL | ||
482 | instead. | ||