tpm: device class for tpm

Added own device class for TPM. Uses MISC_MAJOR:TPM_MINOR for the
first character device in order to retain backwards compatibility.
Added tpm_dev_release() back attached to the character device.

I've been running this code now for a while on my laptop (Lenovo
T430S) TrouSerS works perfectly without modifications. I don't
believe it breaks anything significantly.

The sysfs attributes that have been placed under the wrong place
and are against sysfs-rules.txt should be probably left to
stagnate under platform device directory and start defining
new sysfs attributes to the char device directory.

Guidelines for future TPM sysfs attributes should be probably
along the lines of

- Single flat set of mandatory sysfs attributes. For example,
  current PPI interface is way way too rich when you only want
  to use it to clear and activate the TPM.

- Define sysfs attribute if and only if there's no way to get
  the value from ring-3. No attributes for TPM properties. It's
  just unnecessary maintenance hurdle that we don't want.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jasob Gunthorpe <jason.gunthorpe@obsidianresearch.com>
Reviewed-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Tested-by: Scot Doyle <lkml14@scotdoyle.com>
Tested-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>

1 files changed, 11 insertions, 11 deletions

diff --git a/Documentation/ABI/stable/sysfs-class-tpm b/Documentation/ABI/stable/sysfs-class-tpm
index a60b45e2493b..9f790eebb5d2 100644
--- a/Documentation/ABI/stable/sysfs-class-tpm
+++ b/Documentation/ABI/stable/sysfs-class-tpm
@@ -1,4 +1,4 @@
-What:           /sys/class/misc/tpmX/device/
+What:           /sys/class/tpm/tpmX/device/
 Date:           April 2005
 KernelVersion:  2.6.12
 Contact:        tpmdd-devel@lists.sf.net
@@ -6,7 +6,7 @@ Description:	The device/ directory under a specific TPM instance exposes
                 the properties of that TPM chip
 
 
-What:           /sys/class/misc/tpmX/device/active
+What:           /sys/class/tpm/tpmX/device/active
 Date:           April 2006
 KernelVersion:  2.6.17
 Contact:        tpmdd-devel@lists.sf.net
@@ -18,7 +18,7 @@ Description:	The "active" property prints a '1' if the TPM chip is accepting
                 section 17 for more information on which commands are
                 available.
 
-What:           /sys/class/misc/tpmX/device/cancel
+What:           /sys/class/tpm/tpmX/device/cancel
 Date:           June 2005
 KernelVersion:  2.6.13
 Contact:        tpmdd-devel@lists.sf.net
@@ -26,7 +26,7 @@ Description:	The "cancel" property allows you to cancel the currently
                 pending TPM command. Writing any value to cancel will call the
                 TPM vendor specific cancel operation.
 
-What:           /sys/class/misc/tpmX/device/caps
+What:           /sys/class/tpm/tpmX/device/caps
 Date:           April 2005
 KernelVersion:  2.6.12
 Contact:        tpmdd-devel@lists.sf.net
@@ -43,7 +43,7 @@ Description:	The "caps" property contains TPM manufacturer and version info.
                 the chip supports. Firmware version is that of the chip and
                 is manufacturer specific.
 
-What:           /sys/class/misc/tpmX/device/durations
+What:           /sys/class/tpm/tpmX/device/durations
 Date:           March 2011
 KernelVersion:  3.1
 Contact:        tpmdd-devel@lists.sf.net
@@ -66,7 +66,7 @@ Description:	The "durations" property shows the 3 vendor-specific values
                 scaled to be displayed in usecs. In this case "[adjusted]"
                 will be displayed in place of "[original]".
 
-What:           /sys/class/misc/tpmX/device/enabled
+What:           /sys/class/tpm/tpmX/device/enabled
 Date:           April 2006
 KernelVersion:  2.6.17
 Contact:        tpmdd-devel@lists.sf.net
@@ -75,7 +75,7 @@ Description:	The "enabled" property prints a '1' if the TPM chip is enabled,
                 may be visible but produce a '0' after some operation that
                 disables the TPM.
 
-What:           /sys/class/misc/tpmX/device/owned
+What:           /sys/class/tpm/tpmX/device/owned
 Date:           April 2006
 KernelVersion:  2.6.17
 Contact:        tpmdd-devel@lists.sf.net
@@ -83,7 +83,7 @@ Description:	The "owned" property produces a '1' if the TPM_TakeOwnership
                 ordinal has been executed successfully in the chip. A '0'
                 indicates that ownership hasn't been taken.
 
-What:           /sys/class/misc/tpmX/device/pcrs
+What:           /sys/class/tpm/tpmX/device/pcrs
 Date:           April 2005
 KernelVersion:  2.6.12
 Contact:        tpmdd-devel@lists.sf.net
@@ -106,7 +106,7 @@ Description:	The "pcrs" property will dump the current value of all Platform
                 1.2 chips, PCRs represent SHA-1 hashes, which are 20 bytes
                 long. Use the "caps" property to determine TPM version.
 
-What:           /sys/class/misc/tpmX/device/pubek
+What:           /sys/class/tpm/tpmX/device/pubek
 Date:           April 2005
 KernelVersion:  2.6.12
 Contact:        tpmdd-devel@lists.sf.net
@@ -158,7 +158,7 @@ Description:	The "pubek" property will return the TPM's public endorsement
                 Modulus Length: 256 (bytes)
                 Modulus:        The 256 byte Endorsement Key modulus
 
-What:           /sys/class/misc/tpmX/device/temp_deactivated
+What:           /sys/class/tpm/tpmX/device/temp_deactivated
 Date:           April 2006
 KernelVersion:  2.6.17
 Contact:        tpmdd-devel@lists.sf.net
@@ -167,7 +167,7 @@ Description:	The "temp_deactivated" property returns a '1' if the chip has
                 cycle. Whether a warm boot (reboot) will clear a TPM chip
                 from a temp_deactivated state is platform specific.
 
-What:           /sys/class/misc/tpmX/device/timeouts
+What:           /sys/class/tpm/tpmX/device/timeouts
 Date:           March 2011
 KernelVersion:  3.1
 Contact:        tpmdd-devel@lists.sf.net