diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-05-27 03:10:38 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-05-27 02:10:35 -0400 |
commit | 16f762a2ac5ecf8a11f6f0332e46cc3459220da5 (patch) | |
tree | a54f013d037637a91ceac237b2b0455b29cf45d4 /Documentation/perf_counter/util/abspath.c | |
parent | 815e777f913ed54ddb449d2854015c65b4ecbfe3 (diff) |
perf_counter tools: Introduce stricter C code checking
Tighten up our C code requirements:
- disallow warnings
- disallow declarations-mixed-with-statements
- require proper prototypes
- require C99 (with gcc extensions)
Fix up a ton of problems these measures unearth:
- unused functions
- needlessly global functions
- missing prototypes
- code mixed with declarations
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20090526222155.GJ4424@ghostprotocols.net>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'Documentation/perf_counter/util/abspath.c')
-rw-r--r-- | Documentation/perf_counter/util/abspath.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/perf_counter/util/abspath.c b/Documentation/perf_counter/util/abspath.c index 649f34f83365..61d33b81fc97 100644 --- a/Documentation/perf_counter/util/abspath.c +++ b/Documentation/perf_counter/util/abspath.c | |||
@@ -5,7 +5,7 @@ | |||
5 | * symlink to a directory, we do not want to say it is a directory when | 5 | * symlink to a directory, we do not want to say it is a directory when |
6 | * dealing with tracked content in the working tree. | 6 | * dealing with tracked content in the working tree. |
7 | */ | 7 | */ |
8 | int is_directory(const char *path) | 8 | static int is_directory(const char *path) |
9 | { | 9 | { |
10 | struct stat st; | 10 | struct stat st; |
11 | return (!stat(path, &st) && S_ISDIR(st.st_mode)); | 11 | return (!stat(path, &st) && S_ISDIR(st.st_mode)); |