diff options
author | Eric Dumazet <edumazet@google.com> | 2014-11-18 02:06:20 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-11-19 14:57:01 -0500 |
commit | 355a901e6cf1b2b763ec85caa2a9f04fbcc4ab4a (patch) | |
tree | e91e6de26d24dd3105aa85b678d809e7ffd7749d /Documentation/networking/z8530drv.txt | |
parent | baeababb5b85d5c4e6c917efe2a1504179438d3b (diff) |
tcp: make connect() mem charging friendly
While working on sk_forward_alloc problems reported by Denys
Fedoryshchenko, we found that tcp connect() (and fastopen) do not call
sk_wmem_schedule() for SYN packet (and/or SYN/DATA packet), so
sk_forward_alloc is negative while connect is in progress.
We can fix this by calling regular sk_stream_alloc_skb() both for the
SYN packet (in tcp_connect()) and the syn_data packet in
tcp_send_syn_data()
Then, tcp_send_syn_data() can avoid copying syn_data as we simply
can manipulate syn_data->cb[] to remove SYN flag (and increment seq)
Instead of open coding memcpy_fromiovecend(), simply use this helper.
This leaves in socket write queue clean fast clone skbs.
This was tested against our fastopen packetdrill tests.
Reported-by: Denys Fedoryshchenko <nuclearcat@nuclearcat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'Documentation/networking/z8530drv.txt')
0 files changed, 0 insertions, 0 deletions