aboutsummaryrefslogtreecommitdiffstats
path: root/Documentation/SubmittingPatches
diff options
context:
space:
mode:
authorJacob Keller <jacob.e.keller@intel.com>2014-06-06 17:36:39 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2014-06-06 19:08:11 -0400
commit8401aa1f59975c03eeebd3ac6d264cbdfe9af5de (patch)
treeb1b3a706a2f9259d1328717093a9f9a370d59b72 /Documentation/SubmittingPatches
parentef19470ef87d06ed906e2fbb6c9aeb7aaa9acc56 (diff)
Documentation/SubmittingPatches: describe the Fixes: tag
Update the SubmittingPatches process to include howto about the new 'Fixes:' tag to be used when a patch fixes an issue in a previous commit (found by git-bisect for example). Signed-off-by: Jacob Keller <jacob.e.keller@intel.com> Tested-by: Aaron Brown <aaron.f.brown@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r--Documentation/SubmittingPatches22
1 files changed, 21 insertions, 1 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 2a8e89e13e45..7e9abb8a276b 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -132,6 +132,20 @@ Example:
132 platform_set_drvdata(), but left the variable "dev" unused, 132 platform_set_drvdata(), but left the variable "dev" unused,
133 delete it. 133 delete it.
134 134
135If your patch fixes a bug in a specific commit, e.g. you found an issue using
136git-bisect, please use the 'Fixes:' tag with the first 12 characters of the
137SHA-1 ID, and the one line summary.
138Example:
139
140 Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
141
142The following git-config settings can be used to add a pretty format for
143outputting the above style in the git log or git show commands
144
145 [core]
146 abbrev = 12
147 [pretty]
148 fixes = Fixes: %h (\"%s\")
135 149
1363) Separate your changes. 1503) Separate your changes.
137 151
@@ -443,7 +457,7 @@ person it names. This tag documents that potentially interested parties
443have been included in the discussion 457have been included in the discussion
444 458
445 459
44614) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by: 46014) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes:
447 461
448If this patch fixes a problem reported by somebody else, consider adding a 462If this patch fixes a problem reported by somebody else, consider adding a
449Reported-by: tag to credit the reporter for their contribution. Please 463Reported-by: tag to credit the reporter for their contribution. Please
@@ -498,6 +512,12 @@ idea was not posted in a public forum. That said, if we diligently credit our
498idea reporters, they will, hopefully, be inspired to help us again in the 512idea reporters, they will, hopefully, be inspired to help us again in the
499future. 513future.
500 514
515A Fixes: tag indicates that the patch fixes an issue in a previous commit. It
516is used to make it easy to determine where a bug originated, which can help
517review a bug fix. This tag also assists the stable kernel team in determining
518which stable kernel versions should receive your fix. This is the preferred
519method for indicating a bug fixed by the patch. See #2 above for more details.
520
501 521
50215) The canonical patch format 52215) The canonical patch format
503 523