diff options
author | Jacob Keller <jacob.e.keller@intel.com> | 2014-06-06 17:36:39 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-06 19:08:11 -0400 |
commit | 8401aa1f59975c03eeebd3ac6d264cbdfe9af5de (patch) | |
tree | b1b3a706a2f9259d1328717093a9f9a370d59b72 /Documentation/SubmittingPatches | |
parent | ef19470ef87d06ed906e2fbb6c9aeb7aaa9acc56 (diff) |
Documentation/SubmittingPatches: describe the Fixes: tag
Update the SubmittingPatches process to include howto about the new
'Fixes:' tag to be used when a patch fixes an issue in a previous commit
(found by git-bisect for example).
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r-- | Documentation/SubmittingPatches | 22 |
1 files changed, 21 insertions, 1 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 2a8e89e13e45..7e9abb8a276b 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches | |||
@@ -132,6 +132,20 @@ Example: | |||
132 | platform_set_drvdata(), but left the variable "dev" unused, | 132 | platform_set_drvdata(), but left the variable "dev" unused, |
133 | delete it. | 133 | delete it. |
134 | 134 | ||
135 | If your patch fixes a bug in a specific commit, e.g. you found an issue using | ||
136 | git-bisect, please use the 'Fixes:' tag with the first 12 characters of the | ||
137 | SHA-1 ID, and the one line summary. | ||
138 | Example: | ||
139 | |||
140 | Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()") | ||
141 | |||
142 | The following git-config settings can be used to add a pretty format for | ||
143 | outputting the above style in the git log or git show commands | ||
144 | |||
145 | [core] | ||
146 | abbrev = 12 | ||
147 | [pretty] | ||
148 | fixes = Fixes: %h (\"%s\") | ||
135 | 149 | ||
136 | 3) Separate your changes. | 150 | 3) Separate your changes. |
137 | 151 | ||
@@ -443,7 +457,7 @@ person it names. This tag documents that potentially interested parties | |||
443 | have been included in the discussion | 457 | have been included in the discussion |
444 | 458 | ||
445 | 459 | ||
446 | 14) Using Reported-by:, Tested-by:, Reviewed-by: and Suggested-by: | 460 | 14) Using Reported-by:, Tested-by:, Reviewed-by:, Suggested-by: and Fixes: |
447 | 461 | ||
448 | If this patch fixes a problem reported by somebody else, consider adding a | 462 | If this patch fixes a problem reported by somebody else, consider adding a |
449 | Reported-by: tag to credit the reporter for their contribution. Please | 463 | Reported-by: tag to credit the reporter for their contribution. Please |
@@ -498,6 +512,12 @@ idea was not posted in a public forum. That said, if we diligently credit our | |||
498 | idea reporters, they will, hopefully, be inspired to help us again in the | 512 | idea reporters, they will, hopefully, be inspired to help us again in the |
499 | future. | 513 | future. |
500 | 514 | ||
515 | A Fixes: tag indicates that the patch fixes an issue in a previous commit. It | ||
516 | is used to make it easy to determine where a bug originated, which can help | ||
517 | review a bug fix. This tag also assists the stable kernel team in determining | ||
518 | which stable kernel versions should receive your fix. This is the preferred | ||
519 | method for indicating a bug fixed by the patch. See #2 above for more details. | ||
520 | |||
501 | 521 | ||
502 | 15) The canonical patch format | 522 | 15) The canonical patch format |
503 | 523 | ||