diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2007-06-08 16:46:45 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-06-08 20:23:32 -0400 |
commit | 0f44cd23a5a2e26191a28ab6e91bd0c7849c8e0f (patch) | |
tree | 7cb971c18e4bf6784ea0ca1826fdb425effbeba9 /Documentation/SubmittingPatches | |
parent | a47653fc2643cf61bcabba8c9ff5c45517c089ba (diff) |
document Acked-by:
Explain what we use Acked-by: for, and how it differs from Signed-off-by:
Acked-by: Dave Jones <davej@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'Documentation/SubmittingPatches')
-rw-r--r-- | Documentation/SubmittingPatches | 26 |
1 files changed, 25 insertions, 1 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index d91125ab6f49..0958e97d4bf4 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches | |||
@@ -340,8 +340,32 @@ now, but you can do this to mark internal company procedures or just | |||
340 | point out some special detail about the sign-off. | 340 | point out some special detail about the sign-off. |
341 | 341 | ||
342 | 342 | ||
343 | 13) When to use Acked-by: | ||
343 | 344 | ||
344 | 13) The canonical patch format | 345 | The Signed-off-by: tag indicates that the signer was involved in the |
346 | development of the patch, or that he/she was in the patch's delivery path. | ||
347 | |||
348 | If a person was not directly involved in the preparation or handling of a | ||
349 | patch but wishes to signify and record their approval of it then they can | ||
350 | arrange to have an Acked-by: line added to the patch's changelog. | ||
351 | |||
352 | Acked-by: is often used by the maintainer of the affected code when that | ||
353 | maintainer neither contributed to nor forwarded the patch. | ||
354 | |||
355 | Acked-by: is not as formal as Signed-off-by:. It is a record that the acker | ||
356 | has at least reviewed the patch and has indicated acceptance. Hence patch | ||
357 | mergers will sometimes manually convert an acker's "yep, looks good to me" | ||
358 | into an Acked-by:. | ||
359 | |||
360 | Acked-by: does not necessarily indicate acknowledgement of the entire patch. | ||
361 | For example, if a patch affects multiple subsystems and has an Acked-by: from | ||
362 | one subsystem maintainer then this usually indicates acknowledgement of just | ||
363 | the part which affects that maintainer's code. Judgement should be used here. | ||
364 | When in doubt people should refer to the original discussion in the mailing | ||
365 | list archives. | ||
366 | |||
367 | |||
368 | 14) The canonical patch format | ||
345 | 369 | ||
346 | The canonical patch subject line is: | 370 | The canonical patch subject line is: |
347 | 371 | ||