diff options
author | David Brownell <david-b@pacbell.net> | 2008-02-01 14:42:05 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2008-04-25 00:16:34 -0400 |
commit | 9776afc8b3dc487557f3f576002520f59be334e6 (patch) | |
tree | caade949e8743344a429041681f16a899b943ff6 | |
parent | dbe0dbb7dfda52140d3469d7035a08dfa874fca2 (diff) |
USB: ehci: minor cleanups
Minor cleanups to the EHCI code: revision history is what source
code repositories should have. Switch to a more standard way to
kick in verbose debugging -- don't be EHCI-specific.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r-- | drivers/usb/host/ehci-dbg.c | 2 | ||||
-rw-r--r-- | drivers/usb/host/ehci-hcd.c | 33 | ||||
-rw-r--r-- | drivers/usb/host/ehci-hub.c | 2 |
3 files changed, 4 insertions, 33 deletions
diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c index 64ebfc5548a3..38eb92e5dc42 100644 --- a/drivers/usb/host/ehci-dbg.c +++ b/drivers/usb/host/ehci-dbg.c | |||
@@ -27,7 +27,7 @@ | |||
27 | #define ehci_warn(ehci, fmt, args...) \ | 27 | #define ehci_warn(ehci, fmt, args...) \ |
28 | dev_warn (ehci_to_hcd(ehci)->self.controller , fmt , ## args ) | 28 | dev_warn (ehci_to_hcd(ehci)->self.controller , fmt , ## args ) |
29 | 29 | ||
30 | #ifdef EHCI_VERBOSE_DEBUG | 30 | #ifdef VERBOSE_DEBUG |
31 | # define vdbg dbg | 31 | # define vdbg dbg |
32 | # define ehci_vdbg ehci_dbg | 32 | # define ehci_vdbg ehci_dbg |
33 | #else | 33 | #else |
diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c index 85074cb36f38..360712207262 100644 --- a/drivers/usb/host/ehci-hcd.c +++ b/drivers/usb/host/ehci-hcd.c | |||
@@ -57,35 +57,6 @@ | |||
57 | * Special thanks to Intel and VIA for providing host controllers to | 57 | * Special thanks to Intel and VIA for providing host controllers to |
58 | * test this driver on, and Cypress (including In-System Design) for | 58 | * test this driver on, and Cypress (including In-System Design) for |
59 | * providing early devices for those host controllers to talk to! | 59 | * providing early devices for those host controllers to talk to! |
60 | * | ||
61 | * HISTORY: | ||
62 | * | ||
63 | * 2004-05-10 Root hub and PCI suspend/resume support; remote wakeup. (db) | ||
64 | * 2004-02-24 Replace pci_* with generic dma_* API calls (dsaxena@plexity.net) | ||
65 | * 2003-12-29 Rewritten high speed iso transfer support (by Michal Sojka, | ||
66 | * <sojkam@centrum.cz>, updates by DB). | ||
67 | * | ||
68 | * 2002-11-29 Correct handling for hw async_next register. | ||
69 | * 2002-08-06 Handling for bulk and interrupt transfers is mostly shared; | ||
70 | * only scheduling is different, no arbitrary limitations. | ||
71 | * 2002-07-25 Sanity check PCI reads, mostly for better cardbus support, | ||
72 | * clean up HC run state handshaking. | ||
73 | * 2002-05-24 Preliminary FS/LS interrupts, using scheduling shortcuts | ||
74 | * 2002-05-11 Clear TT errors for FS/LS ctrl/bulk. Fill in some other | ||
75 | * missing pieces: enabling 64bit dma, handoff from BIOS/SMM. | ||
76 | * 2002-05-07 Some error path cleanups to report better errors; wmb(); | ||
77 | * use non-CVS version id; better iso bandwidth claim. | ||
78 | * 2002-04-19 Control/bulk/interrupt submit no longer uses giveback() on | ||
79 | * errors in submit path. Bugfixes to interrupt scheduling/processing. | ||
80 | * 2002-03-05 Initial high-speed ISO support; reduce ITD memory; shift | ||
81 | * more checking to generic hcd framework (db). Make it work with | ||
82 | * Philips EHCI; reduce PCI traffic; shorten IRQ path (Rory Bolt). | ||
83 | * 2002-01-14 Minor cleanup; version synch. | ||
84 | * 2002-01-08 Fix roothub handoff of FS/LS to companion controllers. | ||
85 | * 2002-01-04 Control/Bulk queuing behaves. | ||
86 | * | ||
87 | * 2001-12-12 Initial patch version for Linux 2.5.1 kernel. | ||
88 | * 2001-June Works with usb-storage and NEC EHCI on 2.4 | ||
89 | */ | 60 | */ |
90 | 61 | ||
91 | #define DRIVER_VERSION "10 Dec 2004" | 62 | #define DRIVER_VERSION "10 Dec 2004" |
@@ -95,7 +66,7 @@ | |||
95 | static const char hcd_name [] = "ehci_hcd"; | 66 | static const char hcd_name [] = "ehci_hcd"; |
96 | 67 | ||
97 | 68 | ||
98 | #undef EHCI_VERBOSE_DEBUG | 69 | #undef VERBOSE_DEBUG |
99 | #undef EHCI_URB_TRACE | 70 | #undef EHCI_URB_TRACE |
100 | 71 | ||
101 | #ifdef DEBUG | 72 | #ifdef DEBUG |
@@ -676,7 +647,7 @@ static irqreturn_t ehci_irq (struct usb_hcd *hcd) | |||
676 | cmd = ehci_readl(ehci, &ehci->regs->command); | 647 | cmd = ehci_readl(ehci, &ehci->regs->command); |
677 | bh = 0; | 648 | bh = 0; |
678 | 649 | ||
679 | #ifdef EHCI_VERBOSE_DEBUG | 650 | #ifdef VERBOSE_DEBUG |
680 | /* unrequested/ignored: Frame List Rollover */ | 651 | /* unrequested/ignored: Frame List Rollover */ |
681 | dbg_status (ehci, "irq", status); | 652 | dbg_status (ehci, "irq", status); |
682 | #endif | 653 | #endif |
diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c index fea9e47192db..21ac3781f21a 100644 --- a/drivers/usb/host/ehci-hub.c +++ b/drivers/usb/host/ehci-hub.c | |||
@@ -767,7 +767,7 @@ static int ehci_hub_control ( | |||
767 | if (temp & PORT_POWER) | 767 | if (temp & PORT_POWER) |
768 | status |= 1 << USB_PORT_FEAT_POWER; | 768 | status |= 1 << USB_PORT_FEAT_POWER; |
769 | 769 | ||
770 | #ifndef EHCI_VERBOSE_DEBUG | 770 | #ifndef VERBOSE_DEBUG |
771 | if (status & ~0xffff) /* only if wPortChange is interesting */ | 771 | if (status & ~0xffff) /* only if wPortChange is interesting */ |
772 | #endif | 772 | #endif |
773 | dbg_port (ehci, "GetStatus", wIndex + 1, temp); | 773 | dbg_port (ehci, "GetStatus", wIndex + 1, temp); |