diff options
author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2012-11-14 11:20:21 -0500 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2012-11-29 12:30:36 -0500 |
commit | 91c5d67f17784078169bdcce4c21df82ac6c234c (patch) | |
tree | 24c3d53e322c6f0fa5d702bf395573d5f9b1c722 | |
parent | 5cc0dfe043f84a777bf9d66dc48cc2b83709c9ef (diff) |
Input: tca8418_keypad - increase severity of failures in probe()
Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".
Reviewed-by: Alban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r-- | drivers/input/keyboard/tca8418_keypad.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c index 9084327efb3a..8fcce37b089b 100644 --- a/drivers/input/keyboard/tca8418_keypad.c +++ b/drivers/input/keyboard/tca8418_keypad.c | |||
@@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client, | |||
348 | error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols, | 348 | error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols, |
349 | keypad_data->keymap, input); | 349 | keypad_data->keymap, input); |
350 | if (error) { | 350 | if (error) { |
351 | dev_dbg(dev, "Failed to build keymap\n"); | 351 | dev_err(dev, "Failed to build keymap\n"); |
352 | goto fail2; | 352 | goto fail2; |
353 | } | 353 | } |
354 | 354 | ||
@@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client, | |||
367 | IRQF_ONESHOT, | 367 | IRQF_ONESHOT, |
368 | client->name, keypad_data); | 368 | client->name, keypad_data); |
369 | if (error) { | 369 | if (error) { |
370 | dev_dbg(dev, "Unable to claim irq %d; error %d\n", | 370 | dev_err(dev, "Unable to claim irq %d; error %d\n", |
371 | client->irq, error); | 371 | client->irq, error); |
372 | goto fail2; | 372 | goto fail2; |
373 | } | 373 | } |
374 | 374 | ||
375 | error = input_register_device(input); | 375 | error = input_register_device(input); |
376 | if (error) { | 376 | if (error) { |
377 | dev_dbg(dev, "Unable to register input device, error: %d\n", | 377 | dev_err(dev, "Unable to register input device, error: %d\n", |
378 | error); | 378 | error); |
379 | goto fail3; | 379 | goto fail3; |
380 | } | 380 | } |