diff options
author | Borislav Petkov <bp@alien8.de> | 2012-12-23 06:40:45 -0500 |
---|---|---|
committer | Borislav Petkov <bp@suse.de> | 2013-01-22 16:40:03 -0500 |
commit | 0f08669e869e7732846088d67acd2e339c2aa2fb (patch) | |
tree | 34b97df87cdfe8b2bde09cb031f15d932295bf41 | |
parent | 980eec8b20a9093f862a28f0f4bf67e55a9497be (diff) |
EDAC, MCE, AMD: Remove unneeded exports
Initially, those strings describing different parts of an MCE message
were shared with amd64_edac and were therefore exported to modules.
However, all except pp_msgs are used only in one place right now so hide
them and make them static.
No functionality change.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Borislav Petkov <bp@alien8.de>
-rw-r--r-- | drivers/edac/mce_amd.c | 17 | ||||
-rw-r--r-- | drivers/edac/mce_amd.h | 9 |
2 files changed, 8 insertions, 18 deletions
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c index 75441d357d16..f3f0c930d550 100644 --- a/drivers/edac/mce_amd.c +++ b/drivers/edac/mce_amd.c | |||
@@ -39,33 +39,28 @@ EXPORT_SYMBOL_GPL(amd_unregister_ecc_decoder); | |||
39 | */ | 39 | */ |
40 | 40 | ||
41 | /* transaction type */ | 41 | /* transaction type */ |
42 | const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" }; | 42 | static const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" }; |
43 | EXPORT_SYMBOL_GPL(tt_msgs); | ||
44 | 43 | ||
45 | /* cache level */ | 44 | /* cache level */ |
46 | const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" }; | 45 | static const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" }; |
47 | EXPORT_SYMBOL_GPL(ll_msgs); | ||
48 | 46 | ||
49 | /* memory transaction type */ | 47 | /* memory transaction type */ |
50 | const char * const rrrr_msgs[] = { | 48 | static const char * const rrrr_msgs[] = { |
51 | "GEN", "RD", "WR", "DRD", "DWR", "IRD", "PRF", "EV", "SNP" | 49 | "GEN", "RD", "WR", "DRD", "DWR", "IRD", "PRF", "EV", "SNP" |
52 | }; | 50 | }; |
53 | EXPORT_SYMBOL_GPL(rrrr_msgs); | ||
54 | 51 | ||
55 | /* participating processor */ | 52 | /* participating processor */ |
56 | const char * const pp_msgs[] = { "SRC", "RES", "OBS", "GEN" }; | 53 | const char * const pp_msgs[] = { "SRC", "RES", "OBS", "GEN" }; |
57 | EXPORT_SYMBOL_GPL(pp_msgs); | 54 | EXPORT_SYMBOL_GPL(pp_msgs); |
58 | 55 | ||
59 | /* request timeout */ | 56 | /* request timeout */ |
60 | const char * const to_msgs[] = { "no timeout", "timed out" }; | 57 | static const char * const to_msgs[] = { "no timeout", "timed out" }; |
61 | EXPORT_SYMBOL_GPL(to_msgs); | ||
62 | 58 | ||
63 | /* memory or i/o */ | 59 | /* memory or i/o */ |
64 | const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" }; | 60 | static const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" }; |
65 | EXPORT_SYMBOL_GPL(ii_msgs); | ||
66 | 61 | ||
67 | /* internal error type */ | 62 | /* internal error type */ |
68 | const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" }; | 63 | static const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" }; |
69 | 64 | ||
70 | static const char * const f15h_mc1_mce_desc[] = { | 65 | static const char * const f15h_mc1_mce_desc[] = { |
71 | "UC during a demand linefill from L2", | 66 | "UC during a demand linefill from L2", |
diff --git a/drivers/edac/mce_amd.h b/drivers/edac/mce_amd.h index 28289084017a..51b7e3a36e37 100644 --- a/drivers/edac/mce_amd.h +++ b/drivers/edac/mce_amd.h | |||
@@ -35,6 +35,8 @@ | |||
35 | #define MCI_STATUS_DEFERRED BIT_64(44) | 35 | #define MCI_STATUS_DEFERRED BIT_64(44) |
36 | #define MCI_STATUS_POISON BIT_64(43) | 36 | #define MCI_STATUS_POISON BIT_64(43) |
37 | 37 | ||
38 | extern const char * const pp_msgs[]; | ||
39 | |||
38 | enum tt_ids { | 40 | enum tt_ids { |
39 | TT_INSTR = 0, | 41 | TT_INSTR = 0, |
40 | TT_DATA, | 42 | TT_DATA, |
@@ -68,13 +70,6 @@ enum rrrr_ids { | |||
68 | R4_SNOOP, | 70 | R4_SNOOP, |
69 | }; | 71 | }; |
70 | 72 | ||
71 | extern const char * const tt_msgs[]; | ||
72 | extern const char * const ll_msgs[]; | ||
73 | extern const char * const rrrr_msgs[]; | ||
74 | extern const char * const pp_msgs[]; | ||
75 | extern const char * const to_msgs[]; | ||
76 | extern const char * const ii_msgs[]; | ||
77 | |||
78 | /* | 73 | /* |
79 | * per-family decoder ops | 74 | * per-family decoder ops |
80 | */ | 75 | */ |