diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-05-01 14:31:38 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-05-01 14:31:38 -0400 |
commit | 886c35fbcf6fb2eee15687efc2d64d99b6ad9a4a (patch) | |
tree | e5e928b5197c078af184a65fd36d8428f5433683 | |
parent | 6ed7b6a05dc4332c391134809387220123e82ea7 (diff) | |
parent | f32ddaddf95d8a30be5a41cf681bc8792bc42ec7 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6:
firewire: fw-sbp2: log scsi_target ID at release
ieee1394: fix NULL pointer dereference in sysfs access
-rw-r--r-- | drivers/firewire/fw-sbp2.c | 2 | ||||
-rw-r--r-- | drivers/ieee1394/nodemgr.c | 5 |
2 files changed, 5 insertions, 2 deletions
diff --git a/drivers/firewire/fw-sbp2.c b/drivers/firewire/fw-sbp2.c index 2a999373863e..62e3c9190983 100644 --- a/drivers/firewire/fw-sbp2.c +++ b/drivers/firewire/fw-sbp2.c | |||
@@ -784,7 +784,7 @@ static void sbp2_release_target(struct kref *kref) | |||
784 | kfree(lu); | 784 | kfree(lu); |
785 | } | 785 | } |
786 | scsi_remove_host(shost); | 786 | scsi_remove_host(shost); |
787 | fw_notify("released %s\n", tgt->bus_id); | 787 | fw_notify("released %s, target %d:0:0\n", tgt->bus_id, shost->host_no); |
788 | 788 | ||
789 | fw_unit_put(tgt->unit); | 789 | fw_unit_put(tgt->unit); |
790 | scsi_host_put(shost); | 790 | scsi_host_put(shost); |
diff --git a/drivers/ieee1394/nodemgr.c b/drivers/ieee1394/nodemgr.c index 29d833e71cbf..05710c7c1220 100644 --- a/drivers/ieee1394/nodemgr.c +++ b/drivers/ieee1394/nodemgr.c | |||
@@ -520,8 +520,11 @@ static ssize_t fw_show_drv_device_ids(struct device_driver *drv, char *buf) | |||
520 | char *scratch = buf; | 520 | char *scratch = buf; |
521 | 521 | ||
522 | driver = container_of(drv, struct hpsb_protocol_driver, driver); | 522 | driver = container_of(drv, struct hpsb_protocol_driver, driver); |
523 | id = driver->id_table; | ||
524 | if (!id) | ||
525 | return 0; | ||
523 | 526 | ||
524 | for (id = driver->id_table; id->match_flags != 0; id++) { | 527 | for (; id->match_flags != 0; id++) { |
525 | int need_coma = 0; | 528 | int need_coma = 0; |
526 | 529 | ||
527 | if (id->match_flags & IEEE1394_MATCH_VENDOR_ID) { | 530 | if (id->match_flags & IEEE1394_MATCH_VENDOR_ID) { |