diff options
| author | Roel Kluin <[mailto:roel.kluin@gmail.com]> | 2009-06-23 04:04:14 -0400 |
|---|---|---|
| committer | Jesper Nilsson <jesper.nilsson@axis.com> | 2009-06-23 04:05:05 -0400 |
| commit | 7b994836f09fc3ce7d073ad6f8259a1a84003e02 (patch) | |
| tree | 15572a9cb416840ec007c9695b003b9f59d09002 | |
| parent | 768c31495abe49227a96261b5aa19f34b30882b1 (diff) | |
CRISv10: remove redundant tests on unsigned
Since dmanr is unsigned, negatives are wrapped and caught by the other test.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
| -rw-r--r-- | arch/cris/arch-v10/kernel/dma.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/arch/cris/arch-v10/kernel/dma.c b/arch/cris/arch-v10/kernel/dma.c index 929e68666299..d31504b4a19e 100644 --- a/arch/cris/arch-v10/kernel/dma.c +++ b/arch/cris/arch-v10/kernel/dma.c | |||
| @@ -24,7 +24,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id, | |||
| 24 | unsigned long int gens; | 24 | unsigned long int gens; |
| 25 | int fail = -EINVAL; | 25 | int fail = -EINVAL; |
| 26 | 26 | ||
| 27 | if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) { | 27 | if (dmanr >= MAX_DMA_CHANNELS) { |
| 28 | printk(KERN_CRIT "cris_request_dma: invalid DMA channel %u\n", dmanr); | 28 | printk(KERN_CRIT "cris_request_dma: invalid DMA channel %u\n", dmanr); |
| 29 | return -EINVAL; | 29 | return -EINVAL; |
| 30 | } | 30 | } |
| @@ -213,7 +213,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id, | |||
| 213 | void cris_free_dma(unsigned int dmanr, const char * device_id) | 213 | void cris_free_dma(unsigned int dmanr, const char * device_id) |
| 214 | { | 214 | { |
| 215 | unsigned long flags; | 215 | unsigned long flags; |
| 216 | if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) { | 216 | if (dmanr >= MAX_DMA_CHANNELS) { |
| 217 | printk(KERN_CRIT "cris_free_dma: invalid DMA channel %u\n", dmanr); | 217 | printk(KERN_CRIT "cris_free_dma: invalid DMA channel %u\n", dmanr); |
| 218 | return; | 218 | return; |
| 219 | } | 219 | } |
