diff options
author | Julia Lawall <julia@diku.dk> | 2010-08-09 20:18:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-08-09 23:44:54 -0400 |
commit | e7d86340793e7162126926ec9d226c68f4e37f94 (patch) | |
tree | 4cc90e5466a69b361f1a6eecc2d9fac77e2e1612 | |
parent | 90d7404558fbe6f369d5e27b5ea3ef1e57562d3d (diff) |
mm: use ERR_CAST
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T x;
identifier f;
@@
T f (...) { <+...
- ERR_PTR(PTR_ERR(x))
+ x
...+> }
@@
expression x;
@@
- ERR_PTR(PTR_ERR(x))
+ ERR_CAST(x)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | mm/vmalloc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/vmalloc.c b/mm/vmalloc.c index b7e314b1009f..8b5e4370540b 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c | |||
@@ -732,7 +732,7 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask) | |||
732 | node, gfp_mask); | 732 | node, gfp_mask); |
733 | if (unlikely(IS_ERR(va))) { | 733 | if (unlikely(IS_ERR(va))) { |
734 | kfree(vb); | 734 | kfree(vb); |
735 | return ERR_PTR(PTR_ERR(va)); | 735 | return ERR_CAST(va); |
736 | } | 736 | } |
737 | 737 | ||
738 | err = radix_tree_preload(gfp_mask); | 738 | err = radix_tree_preload(gfp_mask); |