diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-03-06 11:52:03 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-03-06 11:59:12 -0500 |
commit | 9de36825b321fe9fe9cf73260554251af579f4ca (patch) | |
tree | 0bde90baa93cb7a1ac09c6ae73d6ec1d67ac2f44 | |
parent | 769b0441f438c4bb4872cb8560eb6fe51bcc09ee (diff) |
tracing: trace_bprintk() cleanups
Impact: cleanup
Remove a few leftovers and clean up the code a bit.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <1236356510-8381-5-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
-rw-r--r-- | kernel/module.c | 6 | ||||
-rw-r--r-- | kernel/trace/trace.h | 19 |
2 files changed, 8 insertions, 17 deletions
diff --git a/kernel/module.c b/kernel/module.c index 2dece104f9a1..22d7379709da 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -2158,12 +2158,6 @@ static noinline struct module *load_module(void __user *umod, | |||
2158 | &mod->num_tracepoints); | 2158 | &mod->num_tracepoints); |
2159 | #endif | 2159 | #endif |
2160 | 2160 | ||
2161 | #ifdef CONFIG_TRACE_BPRINTK | ||
2162 | mod->trace_bprintk_fmt_start = section_objs(hdr, sechdrs, secstrings, | ||
2163 | "__trace_bprintk_fmt", sizeof(char *), | ||
2164 | &mod->num_trace_bprintk_fmt); | ||
2165 | #endif | ||
2166 | |||
2167 | #ifdef CONFIG_MODVERSIONS | 2161 | #ifdef CONFIG_MODVERSIONS |
2168 | if ((mod->num_syms && !mod->crcs) | 2162 | if ((mod->num_syms && !mod->crcs) |
2169 | || (mod->num_gpl_syms && !mod->gpl_crcs) | 2163 | || (mod->num_gpl_syms && !mod->gpl_crcs) |
diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 6140922392c8..2bfb7d11fc17 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h | |||
@@ -119,14 +119,11 @@ struct userstack_entry { | |||
119 | */ | 119 | */ |
120 | struct print_entry { | 120 | struct print_entry { |
121 | struct trace_entry ent; | 121 | struct trace_entry ent; |
122 | unsigned long ip; | 122 | unsigned long ip; |
123 | int depth; | 123 | int depth; |
124 | const char *fmt; | 124 | const char *fmt; |
125 | u32 buf[]; | 125 | u32 buf[]; |
126 | }; | 126 | }; |
127 | #ifdef CONFIG_TRACE_BPRINTK | ||
128 | extern int trace_bprintk_enable; | ||
129 | #endif | ||
130 | 127 | ||
131 | #define TRACE_OLD_SIZE 88 | 128 | #define TRACE_OLD_SIZE 88 |
132 | 129 | ||
@@ -199,7 +196,7 @@ struct kmemtrace_free_entry { | |||
199 | * trace_flag_type is an enumeration that holds different | 196 | * trace_flag_type is an enumeration that holds different |
200 | * states when a trace occurs. These are: | 197 | * states when a trace occurs. These are: |
201 | * IRQS_OFF - interrupts were disabled | 198 | * IRQS_OFF - interrupts were disabled |
202 | * IRQS_NOSUPPORT - arch does not support irqs_disabled_flags | 199 | * IRQS_NOSUPPORT - arch does not support irqs_disabled_flags |
203 | * NEED_RESCED - reschedule is requested | 200 | * NEED_RESCED - reschedule is requested |
204 | * HARDIRQ - inside an interrupt handler | 201 | * HARDIRQ - inside an interrupt handler |
205 | * SOFTIRQ - inside a softirq handler | 202 | * SOFTIRQ - inside a softirq handler |
@@ -302,7 +299,7 @@ extern void __ftrace_bad_type(void); | |||
302 | IF_ASSIGN(var, ent, struct ftrace_graph_ret_entry, \ | 299 | IF_ASSIGN(var, ent, struct ftrace_graph_ret_entry, \ |
303 | TRACE_GRAPH_RET); \ | 300 | TRACE_GRAPH_RET); \ |
304 | IF_ASSIGN(var, ent, struct hw_branch_entry, TRACE_HW_BRANCHES);\ | 301 | IF_ASSIGN(var, ent, struct hw_branch_entry, TRACE_HW_BRANCHES);\ |
305 | IF_ASSIGN(var, ent, struct trace_power, TRACE_POWER); \ | 302 | IF_ASSIGN(var, ent, struct trace_power, TRACE_POWER); \ |
306 | IF_ASSIGN(var, ent, struct kmemtrace_alloc_entry, \ | 303 | IF_ASSIGN(var, ent, struct kmemtrace_alloc_entry, \ |
307 | TRACE_KMEM_ALLOC); \ | 304 | TRACE_KMEM_ALLOC); \ |
308 | IF_ASSIGN(var, ent, struct kmemtrace_free_entry, \ | 305 | IF_ASSIGN(var, ent, struct kmemtrace_free_entry, \ |
@@ -325,8 +322,8 @@ enum print_line_t { | |||
325 | * flags value in struct tracer_flags. | 322 | * flags value in struct tracer_flags. |
326 | */ | 323 | */ |
327 | struct tracer_opt { | 324 | struct tracer_opt { |
328 | const char *name; /* Will appear on the trace_options file */ | 325 | const char *name; /* Will appear on the trace_options file */ |
329 | u32 bit; /* Mask assigned in val field in tracer_flags */ | 326 | u32 bit; /* Mask assigned in val field in tracer_flags */ |
330 | }; | 327 | }; |
331 | 328 | ||
332 | /* | 329 | /* |
@@ -335,7 +332,7 @@ struct tracer_opt { | |||
335 | */ | 332 | */ |
336 | struct tracer_flags { | 333 | struct tracer_flags { |
337 | u32 val; | 334 | u32 val; |
338 | struct tracer_opt *opts; | 335 | struct tracer_opt *opts; |
339 | }; | 336 | }; |
340 | 337 | ||
341 | /* Makes more easy to define a tracer opt */ | 338 | /* Makes more easy to define a tracer opt */ |
@@ -390,7 +387,7 @@ struct tracer { | |||
390 | int (*set_flag)(u32 old_flags, u32 bit, int set); | 387 | int (*set_flag)(u32 old_flags, u32 bit, int set); |
391 | struct tracer *next; | 388 | struct tracer *next; |
392 | int print_max; | 389 | int print_max; |
393 | struct tracer_flags *flags; | 390 | struct tracer_flags *flags; |
394 | struct tracer_stat *stats; | 391 | struct tracer_stat *stats; |
395 | }; | 392 | }; |
396 | 393 | ||