diff options
author | Klaus Kudielka <klaus.kudielka@gmx.net> | 2007-05-08 03:26:25 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-05-08 14:15:03 -0400 |
commit | 7c4e95bf483231d55bc0d491bc585bb9b7e852b8 (patch) | |
tree | 13f9950574757685c639b141292294a7e99ee879 | |
parent | 9b3af29bf33bfe08c604769632799d27d56ae103 (diff) |
fix cyclades.h for x86_64 (and probably others)
At least on x86_64 the present cyclades.h is broken due to the wrong size
of uclong. This affects, of course, both the kernel and the user-level
utilities. The symptom is that cyzload refuses to load the firmware. I
also managed to freeze the machine when unloading the module.
The patch below fixes this in an architecture-independent way. I have
tested it with 2.6.19 and the driver works fine again with a Cyclades-Z on
an Athlon 64 X2.
[akpm@linux-foundation.org: fix warnings]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | drivers/char/cyclades.c | 2 | ||||
-rw-r--r-- | include/linux/cyclades.h | 14 |
2 files changed, 7 insertions, 9 deletions
diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index 16dc5d1d3cb4..7f73bff0c81c 100644 --- a/drivers/char/cyclades.c +++ b/drivers/char/cyclades.c | |||
@@ -1533,7 +1533,7 @@ cyz_issue_cmd(struct cyclades_card *cinfo, | |||
1533 | struct FIRM_ID __iomem *firm_id; | 1533 | struct FIRM_ID __iomem *firm_id; |
1534 | struct ZFW_CTRL __iomem *zfw_ctrl; | 1534 | struct ZFW_CTRL __iomem *zfw_ctrl; |
1535 | struct BOARD_CTRL __iomem *board_ctrl; | 1535 | struct BOARD_CTRL __iomem *board_ctrl; |
1536 | unsigned long __iomem *pci_doorbell; | 1536 | uclong __iomem *pci_doorbell; |
1537 | int index; | 1537 | int index; |
1538 | 1538 | ||
1539 | firm_id = cinfo->base_addr + ID_ADDRESS; | 1539 | firm_id = cinfo->base_addr + ID_ADDRESS; |
diff --git a/include/linux/cyclades.h b/include/linux/cyclades.h index 46d8254c1a79..a6865f0479f7 100644 --- a/include/linux/cyclades.h +++ b/include/linux/cyclades.h | |||
@@ -149,14 +149,12 @@ struct CYZ_BOOT_CTRL { | |||
149 | * architectures and compilers. | 149 | * architectures and compilers. |
150 | */ | 150 | */ |
151 | 151 | ||
152 | #if defined(__alpha__) | 152 | #include <asm/types.h> |
153 | typedef unsigned long ucdouble; /* 64 bits, unsigned */ | 153 | |
154 | typedef unsigned int uclong; /* 32 bits, unsigned */ | 154 | typedef __u64 ucdouble; /* 64 bits, unsigned */ |
155 | #else | 155 | typedef __u32 uclong; /* 32 bits, unsigned */ |
156 | typedef unsigned long uclong; /* 32 bits, unsigned */ | 156 | typedef __u16 ucshort; /* 16 bits, unsigned */ |
157 | #endif | 157 | typedef __u8 ucchar; /* 8 bits, unsigned */ |
158 | typedef unsigned short ucshort; /* 16 bits, unsigned */ | ||
159 | typedef unsigned char ucchar; /* 8 bits, unsigned */ | ||
160 | 158 | ||
161 | /* | 159 | /* |
162 | * Memory Window Sizes | 160 | * Memory Window Sizes |