aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@infradead.org>2007-08-16 01:38:19 -0400
committerTim Shimmin <tes@chook.melbourne.sgi.com>2007-09-05 00:50:26 -0400
commit265c1fac38e37e828df09965406e9cc20bfa3588 (patch)
tree6f977c9c373bf17ccb7cf79e040cdb9980e526c7
parentee5c80239d5f152d99f69165afbd115518353563 (diff)
[XFS] fix sparse shadowed variable warnings
- in xfs_probe_cluster rename the inner len to pg_len. There's no harm here because the outer len isn't used after the inner len comes into existence but it keeps the code clean. - in xfs_da_do_buf remove the inner i because they don't overlap and they are both the same type. SGI-PV: 968555 SGI-Modid: xfs-linux-melb:xfs-kern:29311a Signed-off-by: Christoph Hellwig <hch@infradead.org> Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Tim Shimmin <tes@sgi.com>
-rw-r--r--fs/xfs/linux-2.6/xfs_aops.c8
-rw-r--r--fs/xfs/xfs_da_btree.c1
2 files changed, 4 insertions, 5 deletions
diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c
index fd4105d662e0..d9c40fe64195 100644
--- a/fs/xfs/linux-2.6/xfs_aops.c
+++ b/fs/xfs/linux-2.6/xfs_aops.c
@@ -652,7 +652,7 @@ xfs_probe_cluster(
652 652
653 for (i = 0; i < pagevec_count(&pvec); i++) { 653 for (i = 0; i < pagevec_count(&pvec); i++) {
654 struct page *page = pvec.pages[i]; 654 struct page *page = pvec.pages[i];
655 size_t pg_offset, len = 0; 655 size_t pg_offset, pg_len = 0;
656 656
657 if (tindex == tlast) { 657 if (tindex == tlast) {
658 pg_offset = 658 pg_offset =
@@ -665,16 +665,16 @@ xfs_probe_cluster(
665 pg_offset = PAGE_CACHE_SIZE; 665 pg_offset = PAGE_CACHE_SIZE;
666 666
667 if (page->index == tindex && !TestSetPageLocked(page)) { 667 if (page->index == tindex && !TestSetPageLocked(page)) {
668 len = xfs_probe_page(page, pg_offset, mapped); 668 pg_len = xfs_probe_page(page, pg_offset, mapped);
669 unlock_page(page); 669 unlock_page(page);
670 } 670 }
671 671
672 if (!len) { 672 if (!pg_len) {
673 done = 1; 673 done = 1;
674 break; 674 break;
675 } 675 }
676 676
677 total += len; 677 total += pg_len;
678 tindex++; 678 tindex++;
679 } 679 }
680 680
diff --git a/fs/xfs/xfs_da_btree.c b/fs/xfs/xfs_da_btree.c
index aea37df4aa62..26d09e2e1a7f 100644
--- a/fs/xfs/xfs_da_btree.c
+++ b/fs/xfs/xfs_da_btree.c
@@ -1975,7 +1975,6 @@ xfs_da_do_buf(
1975 error = mappedbno == -2 ? 0 : XFS_ERROR(EFSCORRUPTED); 1975 error = mappedbno == -2 ? 0 : XFS_ERROR(EFSCORRUPTED);
1976 if (unlikely(error == EFSCORRUPTED)) { 1976 if (unlikely(error == EFSCORRUPTED)) {
1977 if (xfs_error_level >= XFS_ERRLEVEL_LOW) { 1977 if (xfs_error_level >= XFS_ERRLEVEL_LOW) {
1978 int i;
1979 cmn_err(CE_ALERT, "xfs_da_do_buf: bno %lld\n", 1978 cmn_err(CE_ALERT, "xfs_da_do_buf: bno %lld\n",
1980 (long long)bno); 1979 (long long)bno);
1981 cmn_err(CE_ALERT, "dir: inode %lld\n", 1980 cmn_err(CE_ALERT, "dir: inode %lld\n",