diff options
author | Adam Jackson <ajax@redhat.com> | 2010-08-25 16:17:34 -0400 |
---|---|---|
committer | David Woodhouse <David.Woodhouse@intel.com> | 2010-09-21 17:35:28 -0400 |
commit | eecfd57f6429d9d8e10be186566ef99fced55163 (patch) | |
tree | 35551f0505dbd39820ffd618d225efa058882f3e | |
parent | 9eecabcb9a924f1e11ba670365fd4babe423045c (diff) |
intel-iommu: Use symbolic values instead of magic numbers in Lenovo w/a
Commit 9eecabcb9a924f1e11ba670365fd4babe423045c ("intel-iommu: Abort
IOMMU setup for igfx if BIOS gave no shadow GTT space") uses a bunch of
magic numbers. Provide #defines for those to make it look slightly saner.
Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
-rw-r--r-- | drivers/pci/intel-iommu.c | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index dee88c6cb3ef..4dfce3dad6ab 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c | |||
@@ -3761,14 +3761,24 @@ static void __devinit quirk_iommu_rwbf(struct pci_dev *dev) | |||
3761 | 3761 | ||
3762 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x2a40, quirk_iommu_rwbf); | 3762 | DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x2a40, quirk_iommu_rwbf); |
3763 | 3763 | ||
3764 | #define GGC 0x52 | ||
3765 | #define GGC_MEMORY_SIZE_MASK (0xf << 8) | ||
3766 | #define GGC_MEMORY_SIZE_NONE (0x0 << 8) | ||
3767 | #define GGC_MEMORY_SIZE_1M (0x1 << 8) | ||
3768 | #define GGC_MEMORY_SIZE_2M (0x3 << 8) | ||
3769 | #define GGC_MEMORY_VT_ENABLED (0x8 << 8) | ||
3770 | #define GGC_MEMORY_SIZE_2M_VT (0x9 << 8) | ||
3771 | #define GGC_MEMORY_SIZE_3M_VT (0xa << 8) | ||
3772 | #define GGC_MEMORY_SIZE_4M_VT (0xb << 8) | ||
3773 | |||
3764 | static void __devinit quirk_calpella_no_shadow_gtt(struct pci_dev *dev) | 3774 | static void __devinit quirk_calpella_no_shadow_gtt(struct pci_dev *dev) |
3765 | { | 3775 | { |
3766 | unsigned short ggc; | 3776 | unsigned short ggc; |
3767 | 3777 | ||
3768 | if (pci_read_config_word(dev, 0x52, &ggc)) | 3778 | if (pci_read_config_word(dev, GGC, &ggc)) |
3769 | return; | 3779 | return; |
3770 | 3780 | ||
3771 | if (!(ggc & 0x800)) { | 3781 | if (!(ggc & GGC_MEMORY_VT_ENABLED)) { |
3772 | printk(KERN_INFO "DMAR: BIOS has allocated no shadow GTT; disabling IOMMU for graphics\n"); | 3782 | printk(KERN_INFO "DMAR: BIOS has allocated no shadow GTT; disabling IOMMU for graphics\n"); |
3773 | dmar_map_gfx = 0; | 3783 | dmar_map_gfx = 0; |
3774 | } | 3784 | } |