aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2008-05-20 02:54:02 -0400
committerArtem Bityutskiy <Artem.Bityutskiy@nokia.com>2008-07-24 06:32:54 -0400
commitbeeea636030622f6de67d15c61f5b311a03d188c (patch)
tree217f6ae5a148a1ef7054aad42ce5664f74c763b2
parent979c9296bdcfded58ebac41905c3397317df0355 (diff)
UBI: add a comment
It is not clear why we schedule PEB for scrubbing in case of -EBADMSG. Elaborate. Requested-by: Kyungmin Park <kmpark@infradead.org> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
-rw-r--r--drivers/mtd/ubi/vtbl.c11
1 files changed, 10 insertions, 1 deletions
diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index 3c4d68f2cfd4..42a7815086b7 100644
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -385,7 +385,16 @@ static struct ubi_vtbl_record *process_lvol(struct ubi_device *ubi,
385 err = ubi_io_read_data(ubi, leb[seb->lnum], seb->pnum, 0, 385 err = ubi_io_read_data(ubi, leb[seb->lnum], seb->pnum, 0,
386 ubi->vtbl_size); 386 ubi->vtbl_size);
387 if (err == UBI_IO_BITFLIPS || err == -EBADMSG) 387 if (err == UBI_IO_BITFLIPS || err == -EBADMSG)
388 /* Scrub the PEB later */ 388 /*
389 * Scrub the PEB later. Note, -EBADMSG indicates an
390 * uncorrectable ECC error, but we have our own CRC and
391 * the data will be checked later. If the data is OK,
392 * the PEB will be scrubbed (because we set
393 * seb->scrub). If the data is not OK, the contents of
394 * the PEB will be recovered from the second copy, and
395 * seb->scrub will be cleared in
396 * 'ubi_scan_add_used()'.
397 */
389 seb->scrub = 1; 398 seb->scrub = 1;
390 else if (err) 399 else if (err)
391 goto out_free; 400 goto out_free;