diff options
author | Tejun Heo <tj@kernel.org> | 2012-12-21 20:57:13 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2012-12-28 16:40:16 -0500 |
commit | 7d0315a2bec2dd7fe9cbe31098bb89536648224e (patch) | |
tree | 252616dc7d08870a1f32364dd7ea3b1a54ec0f2f | |
parent | 7998005bf7a706a1d6bb3cf2e9783b6437e4419d (diff) |
video/exynos: don't use [delayed_]work_pending()
There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it. Most uses are unnecessary
and quite a few of them are buggy.
Remove unnecessary pending tests from exynos_dp_core. Only compile
tested.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
-rw-r--r-- | drivers/video/exynos/exynos_dp_core.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c index 28fd686c6b81..3002a6acce12 100644 --- a/drivers/video/exynos/exynos_dp_core.c +++ b/drivers/video/exynos/exynos_dp_core.c | |||
@@ -1121,8 +1121,7 @@ static int __devexit exynos_dp_remove(struct platform_device *pdev) | |||
1121 | 1121 | ||
1122 | disable_irq(dp->irq); | 1122 | disable_irq(dp->irq); |
1123 | 1123 | ||
1124 | if (work_pending(&dp->hotplug_work)) | 1124 | flush_work(&dp->hotplug_work); |
1125 | flush_work(&dp->hotplug_work); | ||
1126 | 1125 | ||
1127 | if (pdev->dev.of_node) { | 1126 | if (pdev->dev.of_node) { |
1128 | if (dp->phy_addr) | 1127 | if (dp->phy_addr) |
@@ -1144,8 +1143,7 @@ static int exynos_dp_suspend(struct device *dev) | |||
1144 | struct exynos_dp_platdata *pdata = dev->platform_data; | 1143 | struct exynos_dp_platdata *pdata = dev->platform_data; |
1145 | struct exynos_dp_device *dp = dev_get_drvdata(dev); | 1144 | struct exynos_dp_device *dp = dev_get_drvdata(dev); |
1146 | 1145 | ||
1147 | if (work_pending(&dp->hotplug_work)) | 1146 | flush_work(&dp->hotplug_work); |
1148 | flush_work(&dp->hotplug_work); | ||
1149 | 1147 | ||
1150 | if (dev->of_node) { | 1148 | if (dev->of_node) { |
1151 | if (dp->phy_addr) | 1149 | if (dp->phy_addr) |