diff options
author | David S. Miller <davem@davemloft.net> | 2012-07-12 03:41:25 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-07-12 03:41:25 -0400 |
commit | 1ed5c48f231cd00eac0b3d2350ac61e3c825063e (patch) | |
tree | a2ddd1e4c432d7300396814320608ee946030fc1 | |
parent | b587ee3ba21f58b7770a132e6bca5c6658ac5095 (diff) |
net: Remove checks for dst_ops->redirect being NULL.
No longer necessary.
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | net/dccp/ipv4.c | 2 | ||||
-rw-r--r-- | net/dccp/ipv6.c | 2 | ||||
-rw-r--r-- | net/ipv4/tcp_ipv4.c | 2 | ||||
-rw-r--r-- | net/ipv4/xfrm4_policy.c | 3 | ||||
-rw-r--r-- | net/ipv6/ip6_tunnel.c | 6 | ||||
-rw-r--r-- | net/ipv6/tcp_ipv6.c | 2 | ||||
-rw-r--r-- | net/sctp/input.c | 2 |
7 files changed, 8 insertions, 11 deletions
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 8f41a3190858..129ed8f74138 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
@@ -199,7 +199,7 @@ static void dccp_do_redirect(struct sk_buff *skb, struct sock *sk) | |||
199 | { | 199 | { |
200 | struct dst_entry *dst = __sk_dst_check(sk, 0); | 200 | struct dst_entry *dst = __sk_dst_check(sk, 0); |
201 | 201 | ||
202 | if (dst && dst->ops->redirect) | 202 | if (dst) |
203 | dst->ops->redirect(dst, skb); | 203 | dst->ops->redirect(dst, skb); |
204 | } | 204 | } |
205 | 205 | ||
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c index b4d7d28ce6d2..090c0800ce03 100644 --- a/net/dccp/ipv6.c +++ b/net/dccp/ipv6.c | |||
@@ -133,7 +133,7 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
133 | if (type == NDISC_REDIRECT) { | 133 | if (type == NDISC_REDIRECT) { |
134 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); | 134 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); |
135 | 135 | ||
136 | if (dst && dst->ops->redirect) | 136 | if (dst) |
137 | dst->ops->redirect(dst, skb); | 137 | dst->ops->redirect(dst, skb); |
138 | } | 138 | } |
139 | 139 | ||
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 087a8488843f..7a0062cb4ed0 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c | |||
@@ -325,7 +325,7 @@ static void do_redirect(struct sk_buff *skb, struct sock *sk) | |||
325 | { | 325 | { |
326 | struct dst_entry *dst = __sk_dst_check(sk, 0); | 326 | struct dst_entry *dst = __sk_dst_check(sk, 0); |
327 | 327 | ||
328 | if (dst && dst->ops->redirect) | 328 | if (dst) |
329 | dst->ops->redirect(dst, skb); | 329 | dst->ops->redirect(dst, skb); |
330 | } | 330 | } |
331 | 331 | ||
diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c index 258ebd7b268b..737131cef375 100644 --- a/net/ipv4/xfrm4_policy.c +++ b/net/ipv4/xfrm4_policy.c | |||
@@ -207,8 +207,7 @@ static void xfrm4_redirect(struct dst_entry *dst, struct sk_buff *skb) | |||
207 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; | 207 | struct xfrm_dst *xdst = (struct xfrm_dst *)dst; |
208 | struct dst_entry *path = xdst->route; | 208 | struct dst_entry *path = xdst->route; |
209 | 209 | ||
210 | if (path->ops->redirect) | 210 | path->ops->redirect(path, skb); |
211 | path->ops->redirect(path, skb); | ||
212 | } | 211 | } |
213 | 212 | ||
214 | static void xfrm4_dst_destroy(struct dst_entry *dst) | 213 | static void xfrm4_dst_destroy(struct dst_entry *dst) |
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c index 0b5b60ec6f4a..61d106597296 100644 --- a/net/ipv6/ip6_tunnel.c +++ b/net/ipv6/ip6_tunnel.c | |||
@@ -611,10 +611,8 @@ ip4ip6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
611 | 611 | ||
612 | skb_dst(skb2)->ops->update_pmtu(skb_dst(skb2), rel_info); | 612 | skb_dst(skb2)->ops->update_pmtu(skb_dst(skb2), rel_info); |
613 | } | 613 | } |
614 | if (rel_type == ICMP_REDIRECT) { | 614 | if (rel_type == ICMP_REDIRECT) |
615 | if (skb_dst(skb2)->ops->redirect) | 615 | skb_dst(skb2)->ops->redirect(skb_dst(skb2), skb2); |
616 | skb_dst(skb2)->ops->redirect(skb_dst(skb2), skb2); | ||
617 | } | ||
618 | 616 | ||
619 | icmp_send(skb2, rel_type, rel_code, htonl(rel_info)); | 617 | icmp_send(skb2, rel_type, rel_code, htonl(rel_info)); |
620 | 618 | ||
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 7249e4bb9b8a..3071f377145c 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
@@ -366,7 +366,7 @@ static void tcp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt, | |||
366 | if (type == NDISC_REDIRECT) { | 366 | if (type == NDISC_REDIRECT) { |
367 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); | 367 | struct dst_entry *dst = __sk_dst_check(sk, np->dst_cookie); |
368 | 368 | ||
369 | if (dst && dst->ops->redirect) | 369 | if (dst) |
370 | dst->ops->redirect(dst,skb); | 370 | dst->ops->redirect(dst,skb); |
371 | } | 371 | } |
372 | 372 | ||
diff --git a/net/sctp/input.c b/net/sctp/input.c index 5943b7d77ddb..f050d45faa98 100644 --- a/net/sctp/input.c +++ b/net/sctp/input.c | |||
@@ -431,7 +431,7 @@ void sctp_icmp_redirect(struct sock *sk, struct sctp_transport *t, | |||
431 | if (!t) | 431 | if (!t) |
432 | return; | 432 | return; |
433 | dst = sctp_transport_dst_check(t); | 433 | dst = sctp_transport_dst_check(t); |
434 | if (dst && dst->ops->redirect) | 434 | if (dst) |
435 | dst->ops->redirect(dst, skb); | 435 | dst->ops->redirect(dst, skb); |
436 | } | 436 | } |
437 | 437 | ||