aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Wilcox <matthew.r.wilcox@intel.com>2011-03-16 16:29:24 -0400
committerMatthew Wilcox <matthew.r.wilcox@intel.com>2011-11-04 15:53:00 -0400
commit19e899b2f9f89f4a290dd5c9c24d15987a18ab21 (patch)
tree1a402b9452c3b9d45f6cf73a616ec925d8cfcfbd
parentfa92282149842645931580225647238428374758 (diff)
NVMe: Remove outdated comments
The head can never overrun the tail since we won't allocate enough command IDs to let that happen. The status codes are in sync with the spec. Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
-rw-r--r--drivers/block/nvme.c1
-rw-r--r--include/linux/nvme.h1
2 files changed, 0 insertions, 2 deletions
diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
index 740a9c1b81aa..d4f95eb51dc1 100644
--- a/drivers/block/nvme.c
+++ b/drivers/block/nvme.c
@@ -245,7 +245,6 @@ static int nvme_submit_cmd(struct nvme_queue *nvmeq, struct nvme_command *cmd)
245{ 245{
246 unsigned long flags; 246 unsigned long flags;
247 u16 tail; 247 u16 tail;
248 /* XXX: Need to check tail isn't going to overrun head */
249 spin_lock_irqsave(&nvmeq->q_lock, flags); 248 spin_lock_irqsave(&nvmeq->q_lock, flags);
250 tail = nvmeq->sq_tail; 249 tail = nvmeq->sq_tail;
251 memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd)); 250 memcpy(&nvmeq->sq_cmds[tail], cmd, sizeof(*cmd));
diff --git a/include/linux/nvme.h b/include/linux/nvme.h
index c46a9b7988fb..6b5a8d19daf5 100644
--- a/include/linux/nvme.h
+++ b/include/linux/nvme.h
@@ -323,7 +323,6 @@ struct nvme_command {
323 }; 323 };
324}; 324};
325 325
326/* XXX: Sync with spec */
327enum { 326enum {
328 NVME_SC_SUCCESS = 0x0, 327 NVME_SC_SUCCESS = 0x0,
329 NVME_SC_INVALID_OPCODE = 0x1, 328 NVME_SC_INVALID_OPCODE = 0x1,