aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Wu <lekensteyn@gmail.com>2013-08-21 17:17:11 -0400
committerDavid S. Miller <davem@davemloft.net>2013-08-22 17:25:58 -0400
commit15edae91cb2d91131ab3b0c6eebf1fbfc12d643e (patch)
tree9d052047f84bc47fc173582fbdaa8994f6314ed1
parentcb79abc7eca831071c224782151ff6c7a718054d (diff)
r8169: fix invalid register dump
For some reason, my PCIe RTL8111E onboard NIC on a GA-Z68X-UD3H-B3 motherboard reads as FFs when reading from MMIO with a block size larger than 7. Therefore change to reading blocks of four bytes. Ben Hutchings noted that the buffer is large enough to hold all registers, so now all registers are read. Signed-off-by: Peter Wu <lekensteyn@gmail.com> Acked-by: Francois Romieu <romieu@fr.zoreil.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/realtek/r8169.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 93ee49d29317..c0c9e145fd3b 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1897,9 +1897,13 @@ static void rtl8169_get_regs(struct net_device *dev, struct ethtool_regs *regs,
1897 void *p) 1897 void *p)
1898{ 1898{
1899 struct rtl8169_private *tp = netdev_priv(dev); 1899 struct rtl8169_private *tp = netdev_priv(dev);
1900 u32 __iomem *data = tp->mmio_addr;
1901 u32 *dw = p;
1902 int i;
1900 1903
1901 rtl_lock_work(tp); 1904 rtl_lock_work(tp);
1902 memcpy_fromio(p, tp->mmio_addr, regs->len); 1905 for (i = 0; i < R8169_REGS_SIZE; i += 4)
1906 memcpy_fromio(dw++, data++, 4);
1903 rtl_unlock_work(tp); 1907 rtl_unlock_work(tp);
1904} 1908}
1905 1909