diff options
author | Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com> | 2011-05-13 06:30:53 -0400 |
---|---|---|
committer | Ben Dooks <ben-linux@fluff.org> | 2011-05-24 19:20:54 -0400 |
commit | 0511f643cbe6990daf4b53b1268b5c2ea28d1733 (patch) | |
tree | 28853979c95e16aa8b6b8e2d88f595a3553e71dd | |
parent | b5e890f7e70707d1e10e8d4844806d2223e8b36d (diff) |
i2c-nomadik: reset the hw after status check
In case of I2C timeout, reset the HW only after the HW status
is read, otherwise the staus will be lost.
Signed-off-by: Virupax Sadashivpetimath <virupax.sadashivpetimath@stericsson.com>
Reviewed-by: Jonas Aberg <jonas.aberg@stericsson.com>
Reviewed-by: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
-rw-r--r-- | drivers/i2c/busses/i2c-nomadik.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index b2de1a56dc8d..fa7b10639ce2 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c | |||
@@ -428,10 +428,9 @@ static int read_i2c(struct nmk_i2c_dev *dev) | |||
428 | } | 428 | } |
429 | 429 | ||
430 | if (timeout == 0) { | 430 | if (timeout == 0) { |
431 | /* controller has timedout, re-init the h/w */ | 431 | /* Controller timed out */ |
432 | dev_err(&dev->pdev->dev, "read from slave 0x%x timed out\n", | 432 | dev_err(&dev->pdev->dev, "read from slave 0x%x timed out\n", |
433 | dev->cli.slave_adr); | 433 | dev->cli.slave_adr); |
434 | (void) init_hw(dev); | ||
435 | status = -ETIMEDOUT; | 434 | status = -ETIMEDOUT; |
436 | } | 435 | } |
437 | return status; | 436 | return status; |
@@ -516,10 +515,9 @@ static int write_i2c(struct nmk_i2c_dev *dev) | |||
516 | } | 515 | } |
517 | 516 | ||
518 | if (timeout == 0) { | 517 | if (timeout == 0) { |
519 | /* controller has timedout, re-init the h/w */ | 518 | /* Controller timed out */ |
520 | dev_err(&dev->pdev->dev, "write to slave 0x%x timed out\n", | 519 | dev_err(&dev->pdev->dev, "write to slave 0x%x timed out\n", |
521 | dev->cli.slave_adr); | 520 | dev->cli.slave_adr); |
522 | (void) init_hw(dev); | ||
523 | status = -ETIMEDOUT; | 521 | status = -ETIMEDOUT; |
524 | } | 522 | } |
525 | 523 | ||
@@ -638,6 +636,8 @@ static int nmk_i2c_xfer(struct i2c_adapter *i2c_adap, | |||
638 | abort_causes[cause]); | 636 | abort_causes[cause]); |
639 | } | 637 | } |
640 | 638 | ||
639 | (void) init_hw(dev); | ||
640 | |||
641 | status = status ? status : dev->result; | 641 | status = status ? status : dev->result; |
642 | 642 | ||
643 | break; | 643 | break; |