diff options
author | Len Brown <len.brown@intel.com> | 2009-12-26 22:04:03 -0500 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2009-12-30 02:48:52 -0500 |
commit | f27725756be8a2c2dc65eaf70d0b52807aa2f113 (patch) | |
tree | e8875a7dc8821c36759a2e27acc433cecd8b0069 | |
parent | abb631bfe271a9102fb5b05419272b7aec37a974 (diff) |
ACPI: hp-wmi, msi-wmi: clarify that wmi_install_notify_handler() returns an acpi_status
Emphasize that that wmi_install_notify_handler() returns an acpi_status
rather than -errno by by testing ACPI_SUCCESS(), ACPI_FAILURE().
No functional change in this patch, but this confusion caused a bug in dell-wmi.
Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r-- | drivers/platform/x86/hp-wmi.c | 2 | ||||
-rw-r--r-- | drivers/platform/x86/msi-wmi.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 8781d8fa7a57..18bf74136d24 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c | |||
@@ -581,7 +581,7 @@ static int __init hp_wmi_init(void) | |||
581 | if (wmi_has_guid(HPWMI_EVENT_GUID)) { | 581 | if (wmi_has_guid(HPWMI_EVENT_GUID)) { |
582 | err = wmi_install_notify_handler(HPWMI_EVENT_GUID, | 582 | err = wmi_install_notify_handler(HPWMI_EVENT_GUID, |
583 | hp_wmi_notify, NULL); | 583 | hp_wmi_notify, NULL); |
584 | if (!err) | 584 | if (ACPI_SUCCESS(err)) |
585 | hp_wmi_input_setup(); | 585 | hp_wmi_input_setup(); |
586 | } | 586 | } |
587 | 587 | ||
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c index 7f77f908bb01..f746c677adaa 100644 --- a/drivers/platform/x86/msi-wmi.c +++ b/drivers/platform/x86/msi-wmi.c | |||
@@ -236,7 +236,7 @@ static int __init msi_wmi_init(void) | |||
236 | } | 236 | } |
237 | err = wmi_install_notify_handler(MSIWMI_EVENT_GUID, | 237 | err = wmi_install_notify_handler(MSIWMI_EVENT_GUID, |
238 | msi_wmi_notify, NULL); | 238 | msi_wmi_notify, NULL); |
239 | if (err) | 239 | if (ACPI_FAILURE(err)) |
240 | return -EINVAL; | 240 | return -EINVAL; |
241 | 241 | ||
242 | err = msi_wmi_input_setup(); | 242 | err = msi_wmi_input_setup(); |