diff options
author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2009-09-21 15:35:09 -0400 |
---|---|---|
committer | Len Brown <len.brown@intel.com> | 2009-09-25 14:25:52 -0400 |
commit | ea8d82fd316208bd0ffe6f64823d04bcb8c57158 (patch) | |
tree | 56b6edb6f6b9173230118127b898e2964403a118 | |
parent | 78b8e141f8458ba0b8ac53c45bc327112c53887e (diff) |
ACPI: use acpi_device_hid() when possible
Use acpi_device_hid() rather than accessing acpi_device.pnp.hardware_id
directly.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
-rw-r--r-- | drivers/acpi/scan.c | 6 | ||||
-rw-r--r-- | drivers/pnp/pnpacpi/core.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index e9227ea2cb2f..269c0aae4bed 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c | |||
@@ -185,7 +185,7 @@ static ssize_t | |||
185 | acpi_device_hid_show(struct device *dev, struct device_attribute *attr, char *buf) { | 185 | acpi_device_hid_show(struct device *dev, struct device_attribute *attr, char *buf) { |
186 | struct acpi_device *acpi_dev = to_acpi_device(dev); | 186 | struct acpi_device *acpi_dev = to_acpi_device(dev); |
187 | 187 | ||
188 | return sprintf(buf, "%s\n", acpi_dev->pnp.hardware_id); | 188 | return sprintf(buf, "%s\n", acpi_device_hid(acpi_dev)); |
189 | } | 189 | } |
190 | static DEVICE_ATTR(hid, 0444, acpi_device_hid_show, NULL); | 190 | static DEVICE_ATTR(hid, 0444, acpi_device_hid_show, NULL); |
191 | 191 | ||
@@ -501,7 +501,7 @@ static int acpi_device_register(struct acpi_device *device) | |||
501 | * If failed, create one and link it into acpi_bus_id_list | 501 | * If failed, create one and link it into acpi_bus_id_list |
502 | */ | 502 | */ |
503 | list_for_each_entry(acpi_device_bus_id, &acpi_bus_id_list, node) { | 503 | list_for_each_entry(acpi_device_bus_id, &acpi_bus_id_list, node) { |
504 | if(!strcmp(acpi_device_bus_id->bus_id, device->flags.hardware_id? device->pnp.hardware_id : "device")) { | 504 | if (!strcmp(acpi_device_bus_id->bus_id, device->flags.hardware_id ? acpi_device_hid(device) : "device")) { |
505 | acpi_device_bus_id->instance_no ++; | 505 | acpi_device_bus_id->instance_no ++; |
506 | found = 1; | 506 | found = 1; |
507 | kfree(new_bus_id); | 507 | kfree(new_bus_id); |
@@ -510,7 +510,7 @@ static int acpi_device_register(struct acpi_device *device) | |||
510 | } | 510 | } |
511 | if (!found) { | 511 | if (!found) { |
512 | acpi_device_bus_id = new_bus_id; | 512 | acpi_device_bus_id = new_bus_id; |
513 | strcpy(acpi_device_bus_id->bus_id, device->flags.hardware_id ? device->pnp.hardware_id : "device"); | 513 | strcpy(acpi_device_bus_id->bus_id, device->flags.hardware_id ? acpi_device_hid(device) : "device"); |
514 | acpi_device_bus_id->instance_no = 0; | 514 | acpi_device_bus_id->instance_no = 0; |
515 | list_add_tail(&acpi_device_bus_id->node, &acpi_bus_id_list); | 515 | list_add_tail(&acpi_device_bus_id->node, &acpi_bus_id_list); |
516 | } | 516 | } |
diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c index c07fdb94d665..ff963d4dab46 100644 --- a/drivers/pnp/pnpacpi/core.c +++ b/drivers/pnp/pnpacpi/core.c | |||
@@ -234,7 +234,7 @@ static int __init acpi_pnp_match(struct device *dev, void *_pnp) | |||
234 | /* true means it matched */ | 234 | /* true means it matched */ |
235 | return acpi->flags.hardware_id | 235 | return acpi->flags.hardware_id |
236 | && !acpi_get_physical_device(acpi->handle) | 236 | && !acpi_get_physical_device(acpi->handle) |
237 | && compare_pnp_id(pnp->id, acpi->pnp.hardware_id); | 237 | && compare_pnp_id(pnp->id, acpi_device_hid(acpi)); |
238 | } | 238 | } |
239 | 239 | ||
240 | static int __init acpi_pnp_find_device(struct device *dev, acpi_handle * handle) | 240 | static int __init acpi_pnp_find_device(struct device *dev, acpi_handle * handle) |