diff options
author | Chuck Lever <chuck.lever@oracle.com> | 2012-02-15 16:35:08 -0500 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-02-16 14:55:30 -0500 |
commit | dbb9c2a22d32492544765e798386daa2d9da27d2 (patch) | |
tree | 997ad46ec944ec99fcb95f566825c3ea9506ff50 | |
parent | 15a4520621824a3c2eb2de2d1f3984bc1663d3c8 (diff) |
SUNRPC: Use KERN_DEFAULT for debugging printk's
Our dprintk() debugging facility doesn't specify any verbosity level
for it's printk() calls, but it should.
The default verbosity for printk's is KERN_DEFAULT. You might argue
that these are debugging printk's and thus the verbosity should be
KERN_DEBUG. That would mean that to see NFS and SUNRPC debugging
output an admin would also have to boost the syslog verbosity, which
would be insufferably noisy.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | include/linux/sunrpc/debug.h | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h index 2a11eb278f64..b506936f4ce6 100644 --- a/include/linux/sunrpc/debug.h +++ b/include/linux/sunrpc/debug.h | |||
@@ -54,7 +54,11 @@ extern unsigned int nlm_debug; | |||
54 | #undef ifdebug | 54 | #undef ifdebug |
55 | #ifdef RPC_DEBUG | 55 | #ifdef RPC_DEBUG |
56 | # define ifdebug(fac) if (unlikely(rpc_debug & RPCDBG_##fac)) | 56 | # define ifdebug(fac) if (unlikely(rpc_debug & RPCDBG_##fac)) |
57 | # define dfprintk(fac, args...) do { ifdebug(fac) printk(args); } while(0) | 57 | # define dfprintk(fac, args...) \ |
58 | do { \ | ||
59 | ifdebug(fac) \ | ||
60 | printk(KERN_DEFAULT args); \ | ||
61 | } while (0) | ||
58 | # define RPC_IFDEBUG(x) x | 62 | # define RPC_IFDEBUG(x) x |
59 | #else | 63 | #else |
60 | # define ifdebug(fac) if (0) | 64 | # define ifdebug(fac) if (0) |