aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFred Isaman <iisaman@netapp.com>2012-04-20 14:47:41 -0400
committerTrond Myklebust <Trond.Myklebust@netapp.com>2012-04-27 14:10:37 -0400
commitc5996c4efb95bbb80a25acc890357c9eae998eeb (patch)
tree06f0955c48ba20ff1bd28da1261343cb4f2ab7ff
parent31f6852a4c187c031456581b35e146c0d5bbdecd (diff)
NFS: reverse arg order in nfs_initiate_[read|write]
Make it consistent with nfs_initiate_commit. Signed-off-by: Fred Isaman <iisaman@netapp.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r--fs/nfs/internal.h7
-rw-r--r--fs/nfs/nfs4filelayout.c4
-rw-r--r--fs/nfs/read.c5
-rw-r--r--fs/nfs/write.c6
4 files changed, 12 insertions, 10 deletions
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
index 29ab441b22b1..650127fd24bb 100644
--- a/fs/nfs/internal.h
+++ b/fs/nfs/internal.h
@@ -296,7 +296,8 @@ extern int nfs4_get_rootfh(struct nfs_server *server, struct nfs_fh *mntfh);
296 296
297struct nfs_pageio_descriptor; 297struct nfs_pageio_descriptor;
298/* read.c */ 298/* read.c */
299extern int nfs_initiate_read(struct nfs_read_data *data, struct rpc_clnt *clnt, 299extern int nfs_initiate_read(struct rpc_clnt *clnt,
300 struct nfs_read_data *data,
300 const struct rpc_call_ops *call_ops); 301 const struct rpc_call_ops *call_ops);
301extern void nfs_read_prepare(struct rpc_task *task, void *calldata); 302extern void nfs_read_prepare(struct rpc_task *task, void *calldata);
302extern int nfs_generic_pagein(struct nfs_pageio_descriptor *desc, 303extern int nfs_generic_pagein(struct nfs_pageio_descriptor *desc,
@@ -315,8 +316,8 @@ extern void nfs_pageio_init_write_mds(struct nfs_pageio_descriptor *pgio,
315extern void nfs_pageio_reset_write_mds(struct nfs_pageio_descriptor *pgio); 316extern void nfs_pageio_reset_write_mds(struct nfs_pageio_descriptor *pgio);
316extern void nfs_writedata_release(struct nfs_write_data *wdata); 317extern void nfs_writedata_release(struct nfs_write_data *wdata);
317extern void nfs_commit_free(struct nfs_commit_data *p); 318extern void nfs_commit_free(struct nfs_commit_data *p);
318extern int nfs_initiate_write(struct nfs_write_data *data, 319extern int nfs_initiate_write(struct rpc_clnt *clnt,
319 struct rpc_clnt *clnt, 320 struct nfs_write_data *data,
320 const struct rpc_call_ops *call_ops, 321 const struct rpc_call_ops *call_ops,
321 int how); 322 int how);
322extern void nfs_write_prepare(struct rpc_task *task, void *calldata); 323extern void nfs_write_prepare(struct rpc_task *task, void *calldata);
diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index 675ce3b8663c..adbadcb55a39 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -413,7 +413,7 @@ filelayout_read_pagelist(struct nfs_read_data *data)
413 data->mds_offset = offset; 413 data->mds_offset = offset;
414 414
415 /* Perform an asynchronous read to ds */ 415 /* Perform an asynchronous read to ds */
416 status = nfs_initiate_read(data, ds->ds_clp->cl_rpcclient, 416 status = nfs_initiate_read(ds->ds_clp->cl_rpcclient, data,
417 &filelayout_read_call_ops); 417 &filelayout_read_call_ops);
418 BUG_ON(status != 0); 418 BUG_ON(status != 0);
419 return PNFS_ATTEMPTED; 419 return PNFS_ATTEMPTED;
@@ -460,7 +460,7 @@ filelayout_write_pagelist(struct nfs_write_data *data, int sync)
460 data->args.offset = filelayout_get_dserver_offset(lseg, offset); 460 data->args.offset = filelayout_get_dserver_offset(lseg, offset);
461 461
462 /* Perform an asynchronous write */ 462 /* Perform an asynchronous write */
463 status = nfs_initiate_write(data, ds->ds_clp->cl_rpcclient, 463 status = nfs_initiate_write(ds->ds_clp->cl_rpcclient, data,
464 &filelayout_write_call_ops, sync); 464 &filelayout_write_call_ops, sync);
465 BUG_ON(status != 0); 465 BUG_ON(status != 0);
466 return PNFS_ATTEMPTED; 466 return PNFS_ATTEMPTED;
diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index 0a4be28c2ea3..4ddba6706347 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -169,7 +169,8 @@ static void nfs_readpage_release(struct nfs_page *req)
169 nfs_release_request(req); 169 nfs_release_request(req);
170} 170}
171 171
172int nfs_initiate_read(struct nfs_read_data *data, struct rpc_clnt *clnt, 172int nfs_initiate_read(struct rpc_clnt *clnt,
173 struct nfs_read_data *data,
173 const struct rpc_call_ops *call_ops) 174 const struct rpc_call_ops *call_ops)
174{ 175{
175 struct inode *inode = data->inode; 176 struct inode *inode = data->inode;
@@ -240,7 +241,7 @@ static int nfs_do_read(struct nfs_read_data *data,
240{ 241{
241 struct inode *inode = data->args.context->dentry->d_inode; 242 struct inode *inode = data->args.context->dentry->d_inode;
242 243
243 return nfs_initiate_read(data, NFS_CLIENT(inode), call_ops); 244 return nfs_initiate_read(NFS_CLIENT(inode), data, call_ops);
244} 245}
245 246
246static int 247static int
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 54f7c0ffe5c3..76735dd8c9a7 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -836,8 +836,8 @@ static int flush_task_priority(int how)
836 return RPC_PRIORITY_NORMAL; 836 return RPC_PRIORITY_NORMAL;
837} 837}
838 838
839int nfs_initiate_write(struct nfs_write_data *data, 839int nfs_initiate_write(struct rpc_clnt *clnt,
840 struct rpc_clnt *clnt, 840 struct nfs_write_data *data,
841 const struct rpc_call_ops *call_ops, 841 const struct rpc_call_ops *call_ops,
842 int how) 842 int how)
843{ 843{
@@ -937,7 +937,7 @@ static int nfs_do_write(struct nfs_write_data *data,
937{ 937{
938 struct inode *inode = data->args.context->dentry->d_inode; 938 struct inode *inode = data->args.context->dentry->d_inode;
939 939
940 return nfs_initiate_write(data, NFS_CLIENT(inode), call_ops, how); 940 return nfs_initiate_write(NFS_CLIENT(inode), data, call_ops, how);
941} 941}
942 942
943static int nfs_do_multiple_writes(struct list_head *head, 943static int nfs_do_multiple_writes(struct list_head *head,