diff options
author | Hans Verkuil <hverkuil@xs4all.nl> | 2013-07-26 12:43:45 -0400 |
---|---|---|
committer | James Bottomley <JBottomley@Parallels.com> | 2013-08-26 05:33:58 -0400 |
commit | 9504a923924d663e1953f872f0a828e6454a6cfc (patch) | |
tree | 60c25768bd16bdc69cf4e15aafdfc2be15c36b7d | |
parent | b5dc3c4800cc5c2c0b3c93a97eb4c7afa0aae49a (diff) |
[SCSI] pm80xx: fix Adaptec 71605H hang
The IO command size is 128 bytes for these new controllers as opposed to 64
for the old 8001 controller.
The Adaptec out-of-tree driver did this correctly. After comparing the two
this turned out to be the crucial difference.
So don't hardcode the IO command size, instead use pm8001_ha->iomb_size as
that is the correct value for both old and new controllers.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Anand Kumar Santhanam <AnandKumar.Santhanam@pmcs.com>
Acked-by: Jack Wang <xjtuwjp@gmail.com>
Cc: stable@vger.kernel.org # for v3.10 and up
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r-- | drivers/scsi/pm8001/pm8001_hwi.c | 4 | ||||
-rw-r--r-- | drivers/scsi/pm8001/pm80xx_hwi.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c index 5456f5c73593..4a2195752198 100644 --- a/drivers/scsi/pm8001/pm8001_hwi.c +++ b/drivers/scsi/pm8001/pm8001_hwi.c | |||
@@ -221,7 +221,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) | |||
221 | pm8001_ha->main_cfg_tbl.pm8001_tbl.fatal_err_interrupt = 0x01; | 221 | pm8001_ha->main_cfg_tbl.pm8001_tbl.fatal_err_interrupt = 0x01; |
222 | for (i = 0; i < PM8001_MAX_INB_NUM; i++) { | 222 | for (i = 0; i < PM8001_MAX_INB_NUM; i++) { |
223 | pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt = | 223 | pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt = |
224 | PM8001_MPI_QUEUE | (64 << 16) | (0x00<<30); | 224 | PM8001_MPI_QUEUE | (pm8001_ha->iomb_size << 16) | (0x00<<30); |
225 | pm8001_ha->inbnd_q_tbl[i].upper_base_addr = | 225 | pm8001_ha->inbnd_q_tbl[i].upper_base_addr = |
226 | pm8001_ha->memoryMap.region[IB + i].phys_addr_hi; | 226 | pm8001_ha->memoryMap.region[IB + i].phys_addr_hi; |
227 | pm8001_ha->inbnd_q_tbl[i].lower_base_addr = | 227 | pm8001_ha->inbnd_q_tbl[i].lower_base_addr = |
@@ -247,7 +247,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) | |||
247 | } | 247 | } |
248 | for (i = 0; i < PM8001_MAX_OUTB_NUM; i++) { | 248 | for (i = 0; i < PM8001_MAX_OUTB_NUM; i++) { |
249 | pm8001_ha->outbnd_q_tbl[i].element_size_cnt = | 249 | pm8001_ha->outbnd_q_tbl[i].element_size_cnt = |
250 | PM8001_MPI_QUEUE | (64 << 16) | (0x01<<30); | 250 | PM8001_MPI_QUEUE | (pm8001_ha->iomb_size << 16) | (0x01<<30); |
251 | pm8001_ha->outbnd_q_tbl[i].upper_base_addr = | 251 | pm8001_ha->outbnd_q_tbl[i].upper_base_addr = |
252 | pm8001_ha->memoryMap.region[OB + i].phys_addr_hi; | 252 | pm8001_ha->memoryMap.region[OB + i].phys_addr_hi; |
253 | pm8001_ha->outbnd_q_tbl[i].lower_base_addr = | 253 | pm8001_ha->outbnd_q_tbl[i].lower_base_addr = |
diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index 7f77210f5cf3..9f91030211e8 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c | |||
@@ -275,7 +275,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) | |||
275 | 275 | ||
276 | for (i = 0; i < PM8001_MAX_SPCV_INB_NUM; i++) { | 276 | for (i = 0; i < PM8001_MAX_SPCV_INB_NUM; i++) { |
277 | pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt = | 277 | pm8001_ha->inbnd_q_tbl[i].element_pri_size_cnt = |
278 | PM8001_MPI_QUEUE | (64 << 16) | (0x00<<30); | 278 | PM8001_MPI_QUEUE | (pm8001_ha->iomb_size << 16) | (0x00<<30); |
279 | pm8001_ha->inbnd_q_tbl[i].upper_base_addr = | 279 | pm8001_ha->inbnd_q_tbl[i].upper_base_addr = |
280 | pm8001_ha->memoryMap.region[IB + i].phys_addr_hi; | 280 | pm8001_ha->memoryMap.region[IB + i].phys_addr_hi; |
281 | pm8001_ha->inbnd_q_tbl[i].lower_base_addr = | 281 | pm8001_ha->inbnd_q_tbl[i].lower_base_addr = |
@@ -301,7 +301,7 @@ static void init_default_table_values(struct pm8001_hba_info *pm8001_ha) | |||
301 | } | 301 | } |
302 | for (i = 0; i < PM8001_MAX_SPCV_OUTB_NUM; i++) { | 302 | for (i = 0; i < PM8001_MAX_SPCV_OUTB_NUM; i++) { |
303 | pm8001_ha->outbnd_q_tbl[i].element_size_cnt = | 303 | pm8001_ha->outbnd_q_tbl[i].element_size_cnt = |
304 | PM8001_MPI_QUEUE | (64 << 16) | (0x01<<30); | 304 | PM8001_MPI_QUEUE | (pm8001_ha->iomb_size << 16) | (0x01<<30); |
305 | pm8001_ha->outbnd_q_tbl[i].upper_base_addr = | 305 | pm8001_ha->outbnd_q_tbl[i].upper_base_addr = |
306 | pm8001_ha->memoryMap.region[OB + i].phys_addr_hi; | 306 | pm8001_ha->memoryMap.region[OB + i].phys_addr_hi; |
307 | pm8001_ha->outbnd_q_tbl[i].lower_base_addr = | 307 | pm8001_ha->outbnd_q_tbl[i].lower_base_addr = |