aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMing Lei <tom.leiming@gmail.com>2014-05-10 13:01:49 -0400
committerJens Axboe <axboe@fb.com>2014-05-10 17:42:13 -0400
commit60f2df8a29df5f2db2c87fd23122a1cebdf2011a (patch)
tree29357144d3693b6569e6d525873c31c273c9cc56
parent0289b2e110b7824b2f76d194ad6f8f0844e270ad (diff)
blk-mq: bitmap tag: remove barrier in bt_clear_tag()
The barrier isn't necessary because both atomic_dec_and_test() and wake_up() implicate one barrier. Signed-off-by: Ming Lei <tom.leiming@gmail.com> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--block/blk-mq-tag.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index a81b138e89fe..5a83d8e587f7 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -244,7 +244,6 @@ static void bt_clear_tag(struct blk_mq_bitmap_tags *bt, unsigned int tag)
244 244
245 bs = bt_wake_ptr(bt); 245 bs = bt_wake_ptr(bt);
246 if (bs && atomic_dec_and_test(&bs->wait_cnt)) { 246 if (bs && atomic_dec_and_test(&bs->wait_cnt)) {
247 smp_mb__after_clear_bit();
248 atomic_set(&bs->wait_cnt, bt->wake_cnt); 247 atomic_set(&bs->wait_cnt, bt->wake_cnt);
249 bt_index_inc(&bt->wake_index); 248 bt_index_inc(&bt->wake_index);
250 wake_up(&bs->wait); 249 wake_up(&bs->wait);