aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-10-09 03:18:23 -0400
committerThomas Gleixner <tglx@linutronix.de>2012-10-09 15:27:14 -0400
commit5b3900cd409466c0070b234d941650685ad0c791 (patch)
tree1a381a23d3d06cfc8941ee2e5dd400ba6cea6f21
parent26cff4e2aa4d666dc6a120ea34336b5057e3e187 (diff)
timekeeping: Cast raw_interval to u64 to avoid shift overflow
We fixed a bunch of integer overflows in timekeeping code during the 3.6 cycle. I did an audit based on that and found this potential overflow. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: John Stultz <johnstul@us.ibm.com> Link: http://lkml.kernel.org/r/20121009071823.GA19159@elgon.mountain Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: stable@vger.kernel.org
-rw-r--r--kernel/time/timekeeping.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 16280ff3cf82..3eb3fc7c1600 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -1045,7 +1045,7 @@ static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
1045 accumulate_nsecs_to_secs(tk); 1045 accumulate_nsecs_to_secs(tk);
1046 1046
1047 /* Accumulate raw time */ 1047 /* Accumulate raw time */
1048 raw_nsecs = tk->raw_interval << shift; 1048 raw_nsecs = (u64)tk->raw_interval << shift;
1049 raw_nsecs += tk->raw_time.tv_nsec; 1049 raw_nsecs += tk->raw_time.tv_nsec;
1050 if (raw_nsecs >= NSEC_PER_SEC) { 1050 if (raw_nsecs >= NSEC_PER_SEC) {
1051 u64 raw_secs = raw_nsecs; 1051 u64 raw_secs = raw_nsecs;