diff options
author | Sage Weil <sage@newdream.net> | 2012-01-03 15:34:34 -0500 |
---|---|---|
committer | Sage Weil <sage@newdream.net> | 2012-01-10 11:57:03 -0500 |
commit | 56e925b677c5293e5aac73dac09e93b23259f907 (patch) | |
tree | 4faf6862b427a5dfcd150ec8ebd15a77f9295640 | |
parent | 2ff179e650e95c2b21841b21dc46dc2edefd04cd (diff) |
libceph: remove useless return value for osd_client __send_request()
Signed-off-by: Sage Weil <sage@newdream.net>
-rw-r--r-- | net/ceph/osd_client.c | 21 |
1 files changed, 6 insertions, 15 deletions
diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c index f4f3f58f5234..5e254055c910 100644 --- a/net/ceph/osd_client.c +++ b/net/ceph/osd_client.c | |||
@@ -29,8 +29,8 @@ static void __register_request(struct ceph_osd_client *osdc, | |||
29 | struct ceph_osd_request *req); | 29 | struct ceph_osd_request *req); |
30 | static void __unregister_linger_request(struct ceph_osd_client *osdc, | 30 | static void __unregister_linger_request(struct ceph_osd_client *osdc, |
31 | struct ceph_osd_request *req); | 31 | struct ceph_osd_request *req); |
32 | static int __send_request(struct ceph_osd_client *osdc, | 32 | static void __send_request(struct ceph_osd_client *osdc, |
33 | struct ceph_osd_request *req); | 33 | struct ceph_osd_request *req); |
34 | 34 | ||
35 | static int op_needs_trail(int op) | 35 | static int op_needs_trail(int op) |
36 | { | 36 | { |
@@ -1022,8 +1022,8 @@ out: | |||
1022 | /* | 1022 | /* |
1023 | * caller should hold map_sem (for read) and request_mutex | 1023 | * caller should hold map_sem (for read) and request_mutex |
1024 | */ | 1024 | */ |
1025 | static int __send_request(struct ceph_osd_client *osdc, | 1025 | static void __send_request(struct ceph_osd_client *osdc, |
1026 | struct ceph_osd_request *req) | 1026 | struct ceph_osd_request *req) |
1027 | { | 1027 | { |
1028 | struct ceph_osd_request_head *reqhead; | 1028 | struct ceph_osd_request_head *reqhead; |
1029 | 1029 | ||
@@ -1041,7 +1041,6 @@ static int __send_request(struct ceph_osd_client *osdc, | |||
1041 | ceph_msg_get(req->r_request); /* send consumes a ref */ | 1041 | ceph_msg_get(req->r_request); /* send consumes a ref */ |
1042 | ceph_con_send(&req->r_osd->o_con, req->r_request); | 1042 | ceph_con_send(&req->r_osd->o_con, req->r_request); |
1043 | req->r_sent = req->r_osd->o_incarnation; | 1043 | req->r_sent = req->r_osd->o_incarnation; |
1044 | return 0; | ||
1045 | } | 1044 | } |
1046 | 1045 | ||
1047 | /* | 1046 | /* |
@@ -1726,17 +1725,9 @@ int ceph_osdc_start_request(struct ceph_osd_client *osdc, | |||
1726 | dout("send_request %p no up osds in pg\n", req); | 1725 | dout("send_request %p no up osds in pg\n", req); |
1727 | ceph_monc_request_next_osdmap(&osdc->client->monc); | 1726 | ceph_monc_request_next_osdmap(&osdc->client->monc); |
1728 | } else { | 1727 | } else { |
1729 | rc = __send_request(osdc, req); | 1728 | __send_request(osdc, req); |
1730 | if (rc) { | ||
1731 | if (nofail) { | ||
1732 | dout("osdc_start_request failed send, " | ||
1733 | " will retry %lld\n", req->r_tid); | ||
1734 | rc = 0; | ||
1735 | } else { | ||
1736 | __unregister_request(osdc, req); | ||
1737 | } | ||
1738 | } | ||
1739 | } | 1729 | } |
1730 | rc = 0; | ||
1740 | } | 1731 | } |
1741 | 1732 | ||
1742 | out_unlock: | 1733 | out_unlock: |