aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2008-01-25 16:17:08 -0500
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>2008-01-25 16:17:08 -0500
commit4ee06b7e677da4c75f2fcc5fd850543852d18bf2 (patch)
tree0c7c4b1e2be3179cc25e95f4148577cd9047e398
parentf1ca6d37f991347b87d86430db42e2ab139d1b1d (diff)
ide: remove stale ide.h "configuration options"
Remove stale ide.h "configuration options": * INITIAL_MULT_COUNT - always defined to 0 * SUPPORT_SLOW_DATA_PORTS - unused * OK_TO_RESET_CONTROLLER - always defined to 1 * DISABLE_IRQ_NOSYNC - always defined to 0 Leave SUPPORT_VLB_SYNC (defined to 0 for CRIS and FRV, otherwise to 1) for now but disallow overriding it by <asm/ide.h>. There should be no functionality changes caused by this patch. Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
-rw-r--r--drivers/ide/ide-io.c4
-rw-r--r--drivers/ide/ide-iops.c9
-rw-r--r--drivers/ide/ide-probe.c4
-rw-r--r--include/asm-cris/arch-v10/ide.h5
-rw-r--r--include/asm-cris/arch-v32/ide.h5
-rw-r--r--include/asm-frv/ide.h6
-rw-r--r--include/asm-powerpc/ide.h3
-rw-r--r--include/linux/ide.h27
8 files changed, 8 insertions, 55 deletions
diff --git a/drivers/ide/ide-io.c b/drivers/ide/ide-io.c
index 33458fe7f490..4ea8419feeec 100644
--- a/drivers/ide/ide-io.c
+++ b/drivers/ide/ide-io.c
@@ -1469,12 +1469,8 @@ void ide_timer_expiry (unsigned long data)
1469 */ 1469 */
1470 spin_unlock(&ide_lock); 1470 spin_unlock(&ide_lock);
1471 hwif = HWIF(drive); 1471 hwif = HWIF(drive);
1472#if DISABLE_IRQ_NOSYNC
1473 disable_irq_nosync(hwif->irq);
1474#else
1475 /* disable_irq_nosync ?? */ 1472 /* disable_irq_nosync ?? */
1476 disable_irq(hwif->irq); 1473 disable_irq(hwif->irq);
1477#endif /* DISABLE_IRQ_NOSYNC */
1478 /* local CPU only, 1474 /* local CPU only,
1479 * as if we were handling an interrupt */ 1475 * as if we were handling an interrupt */
1480 local_irq_disable(); 1476 local_irq_disable();
diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c
index 6a6d1c188030..617888048eed 100644
--- a/drivers/ide/ide-iops.c
+++ b/drivers/ide/ide-iops.c
@@ -1050,8 +1050,7 @@ static void ide_disk_pre_reset(ide_drive_t *drive)
1050 drive->special.all = 0; 1050 drive->special.all = 0;
1051 drive->special.b.set_geometry = legacy; 1051 drive->special.b.set_geometry = legacy;
1052 drive->special.b.recalibrate = legacy; 1052 drive->special.b.recalibrate = legacy;
1053 if (OK_TO_RESET_CONTROLLER) 1053 drive->mult_count = 0;
1054 drive->mult_count = 0;
1055 if (!drive->keep_settings && !drive->using_dma) 1054 if (!drive->keep_settings && !drive->using_dma)
1056 drive->mult_req = 0; 1055 drive->mult_req = 0;
1057 if (drive->mult_req != drive->mult_count) 1056 if (drive->mult_req != drive->mult_count)
@@ -1136,7 +1135,6 @@ static ide_startstop_t do_reset1 (ide_drive_t *drive, int do_not_try_atapi)
1136 for (unit = 0; unit < MAX_DRIVES; ++unit) 1135 for (unit = 0; unit < MAX_DRIVES; ++unit)
1137 pre_reset(&hwif->drives[unit]); 1136 pre_reset(&hwif->drives[unit]);
1138 1137
1139#if OK_TO_RESET_CONTROLLER
1140 if (!IDE_CONTROL_REG) { 1138 if (!IDE_CONTROL_REG) {
1141 spin_unlock_irqrestore(&ide_lock, flags); 1139 spin_unlock_irqrestore(&ide_lock, flags);
1142 return ide_stopped; 1140 return ide_stopped;
@@ -1173,11 +1171,8 @@ static ide_startstop_t do_reset1 (ide_drive_t *drive, int do_not_try_atapi)
1173 * state when the disks are reset this way. At least, the Winbond 1171 * state when the disks are reset this way. At least, the Winbond
1174 * 553 documentation says that 1172 * 553 documentation says that
1175 */ 1173 */
1176 if (hwif->resetproc != NULL) { 1174 if (hwif->resetproc)
1177 hwif->resetproc(drive); 1175 hwif->resetproc(drive);
1178 }
1179
1180#endif /* OK_TO_RESET_CONTROLLER */
1181 1176
1182 spin_unlock_irqrestore(&ide_lock, flags); 1177 spin_unlock_irqrestore(&ide_lock, flags);
1183 return ide_started; 1178 return ide_started;
diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
index 0dda7ac0d951..8e5d8dd315af 100644
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -95,10 +95,10 @@ static void ide_disk_init_mult_count(ide_drive_t *drive)
95#ifdef CONFIG_IDEDISK_MULTI_MODE 95#ifdef CONFIG_IDEDISK_MULTI_MODE
96 id->multsect = ((id->max_multsect/2) > 1) ? id->max_multsect : 0; 96 id->multsect = ((id->max_multsect/2) > 1) ? id->max_multsect : 0;
97 id->multsect_valid = id->multsect ? 1 : 0; 97 id->multsect_valid = id->multsect ? 1 : 0;
98 drive->mult_req = id->multsect_valid ? id->max_multsect : INITIAL_MULT_COUNT; 98 drive->mult_req = id->multsect_valid ? id->max_multsect : 0;
99 drive->special.b.set_multmode = drive->mult_req ? 1 : 0; 99 drive->special.b.set_multmode = drive->mult_req ? 1 : 0;
100#else /* original, pre IDE-NFG, per request of AC */ 100#else /* original, pre IDE-NFG, per request of AC */
101 drive->mult_req = INITIAL_MULT_COUNT; 101 drive->mult_req = 0;
102 if (drive->mult_req > id->max_multsect) 102 if (drive->mult_req > id->max_multsect)
103 drive->mult_req = id->max_multsect; 103 drive->mult_req = id->max_multsect;
104 if (drive->mult_req || ((id->multsect_valid & 1) && id->multsect)) 104 if (drive->mult_req || ((id->multsect_valid & 1) && id->multsect))
diff --git a/include/asm-cris/arch-v10/ide.h b/include/asm-cris/arch-v10/ide.h
index 78b301ed7b12..ea34e0d0a388 100644
--- a/include/asm-cris/arch-v10/ide.h
+++ b/include/asm-cris/arch-v10/ide.h
@@ -89,11 +89,6 @@ static inline void ide_init_default_hwifs(void)
89 } 89 }
90} 90}
91 91
92/* some configuration options we don't need */
93
94#undef SUPPORT_VLB_SYNC
95#define SUPPORT_VLB_SYNC 0
96
97#endif /* __KERNEL__ */ 92#endif /* __KERNEL__ */
98 93
99#endif /* __ASMCRIS_IDE_H */ 94#endif /* __ASMCRIS_IDE_H */
diff --git a/include/asm-cris/arch-v32/ide.h b/include/asm-cris/arch-v32/ide.h
index 11296170d057..fb9c3627a5b4 100644
--- a/include/asm-cris/arch-v32/ide.h
+++ b/include/asm-cris/arch-v32/ide.h
@@ -48,11 +48,6 @@ static inline unsigned long ide_default_io_base(int index)
48 return REG_TYPE_CONV(unsigned long, reg_ata_rw_ctrl2, ctrl2); 48 return REG_TYPE_CONV(unsigned long, reg_ata_rw_ctrl2, ctrl2);
49} 49}
50 50
51/* some configuration options we don't need */
52
53#undef SUPPORT_VLB_SYNC
54#define SUPPORT_VLB_SYNC 0
55
56#define IDE_ARCH_ACK_INTR 51#define IDE_ARCH_ACK_INTR
57#define ide_ack_intr(hwif) ((hwif)->ack_intr(hwif)) 52#define ide_ack_intr(hwif) ((hwif)->ack_intr(hwif))
58 53
diff --git a/include/asm-frv/ide.h b/include/asm-frv/ide.h
index f0bd2cb250c1..8c9a540d4344 100644
--- a/include/asm-frv/ide.h
+++ b/include/asm-frv/ide.h
@@ -18,12 +18,6 @@
18#include <asm/io.h> 18#include <asm/io.h>
19#include <asm/irq.h> 19#include <asm/irq.h>
20 20
21#undef SUPPORT_SLOW_DATA_PORTS
22#define SUPPORT_SLOW_DATA_PORTS 0
23
24#undef SUPPORT_VLB_SYNC
25#define SUPPORT_VLB_SYNC 0
26
27#ifndef MAX_HWIFS 21#ifndef MAX_HWIFS
28#define MAX_HWIFS 8 22#define MAX_HWIFS 8
29#endif 23#endif
diff --git a/include/asm-powerpc/ide.h b/include/asm-powerpc/ide.h
index fd7f5a430f0a..6d50310ecaea 100644
--- a/include/asm-powerpc/ide.h
+++ b/include/asm-powerpc/ide.h
@@ -42,9 +42,6 @@ struct ide_machdep_calls {
42 42
43extern struct ide_machdep_calls ppc_ide_md; 43extern struct ide_machdep_calls ppc_ide_md;
44 44
45#undef SUPPORT_SLOW_DATA_PORTS
46#define SUPPORT_SLOW_DATA_PORTS 0
47
48#define IDE_ARCH_OBSOLETE_DEFAULTS 45#define IDE_ARCH_OBSOLETE_DEFAULTS
49 46
50static __inline__ int ide_default_irq(unsigned long base) 47static __inline__ int ide_default_irq(unsigned long base)
diff --git a/include/linux/ide.h b/include/linux/ide.h
index 6dfee2a46f1b..0b088f18d422 100644
--- a/include/linux/ide.h
+++ b/include/linux/ide.h
@@ -27,25 +27,10 @@
27#include <asm/semaphore.h> 27#include <asm/semaphore.h>
28#include <asm/mutex.h> 28#include <asm/mutex.h>
29 29
30/****************************************************************************** 30#if defined(CRIS) || defined(FRV)
31 * IDE driver configuration options (play with these as desired): 31# define SUPPORT_VLB_SYNC 0
32 * 32#else
33 * REALLY_SLOW_IO can be defined in ide.c and ide-cd.c, if necessary 33# define SUPPORT_VLB_SYNC 1
34 */
35#define INITIAL_MULT_COUNT 0 /* off=0; on=2,4,8,16,32, etc.. */
36
37#ifndef SUPPORT_SLOW_DATA_PORTS /* 1 to support slow data ports */
38#define SUPPORT_SLOW_DATA_PORTS 1 /* 0 to reduce kernel size */
39#endif
40#ifndef SUPPORT_VLB_SYNC /* 1 to support weird 32-bit chips */
41#define SUPPORT_VLB_SYNC 1 /* 0 to reduce kernel size */
42#endif
43#ifndef OK_TO_RESET_CONTROLLER /* 1 needed for good error recovery */
44#define OK_TO_RESET_CONTROLLER 1 /* 0 for use with AH2372A/B interface */
45#endif
46
47#ifndef DISABLE_IRQ_NOSYNC
48#define DISABLE_IRQ_NOSYNC 0
49#endif 34#endif
50 35
51/* 36/*
@@ -55,10 +40,6 @@
55 40
56#define IDE_NO_IRQ (-1) 41#define IDE_NO_IRQ (-1)
57 42
58/*
59 * "No user-serviceable parts" beyond this point :)
60 *****************************************************************************/
61
62typedef unsigned char byte; /* used everywhere */ 43typedef unsigned char byte; /* used everywhere */
63 44
64/* 45/*