diff options
author | Eliezer Tamir <eliezer.tamir@linux.intel.com> | 2013-08-25 03:23:46 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-08-28 17:45:48 -0400 |
commit | 3046e2f5b79a86044ac0a29c69610d6ac6a4b882 (patch) | |
tree | 92148960b1400fb5e5c30192530103f5cddd82d0 | |
parent | 64c3b252e9fc8256ef7b1b99ba60492163cd06e8 (diff) |
net: add cpu_relax to busy poll loop
Add a cpu_relaxt to sk_busy_loop.
Julie Cummings reported performance issues when hyperthreading is on.
Arjan van de Ven observed that we should have a cpu_relax() in the
busy poll loop.
Reported-by: Julie Cummings <julie.a.cummings@intel.com>
Signed-off-by: Eliezer Tamir <eliezer.tamir@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | include/net/busy_poll.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/net/busy_poll.h b/include/net/busy_poll.h index 8a358a2c97e6..829627d7b846 100644 --- a/include/net/busy_poll.h +++ b/include/net/busy_poll.h | |||
@@ -123,6 +123,7 @@ static inline bool sk_busy_loop(struct sock *sk, int nonblock) | |||
123 | /* local bh are disabled so it is ok to use _BH */ | 123 | /* local bh are disabled so it is ok to use _BH */ |
124 | NET_ADD_STATS_BH(sock_net(sk), | 124 | NET_ADD_STATS_BH(sock_net(sk), |
125 | LINUX_MIB_BUSYPOLLRXPACKETS, rc); | 125 | LINUX_MIB_BUSYPOLLRXPACKETS, rc); |
126 | cpu_relax(); | ||
126 | 127 | ||
127 | } while (!nonblock && skb_queue_empty(&sk->sk_receive_queue) && | 128 | } while (!nonblock && skb_queue_empty(&sk->sk_receive_queue) && |
128 | !need_resched() && !busy_loop_timeout(end_time)); | 129 | !need_resched() && !busy_loop_timeout(end_time)); |