diff options
author | Michael Ellerman <mpe@ellerman.id.au> | 2014-07-15 07:15:36 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2014-07-28 00:11:23 -0400 |
commit | 144beb2f53894283e0a8a4e6ef32d42b17fc34fd (patch) | |
tree | e6fa376a177aa8a79c68501470ea7b99a3e07dd1 | |
parent | 4e2bf01b21054b9300d2e108f5b8b5e4b803b8b8 (diff) |
powerpc: Update comments in irqflags.h
The comment on TRACE_ENABLE_INTS is incorrect, and appears to have
always been incorrect since the code was merged. It probably came from
an original out-of-tree patch.
Replace it with something that's correct. Also propagate the message to
RECONCILE_IRQ_STATE(), because it's potentially subtle.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | arch/powerpc/include/asm/irqflags.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/arch/powerpc/include/asm/irqflags.h b/arch/powerpc/include/asm/irqflags.h index e20eb95429a8..f2149066fe5d 100644 --- a/arch/powerpc/include/asm/irqflags.h +++ b/arch/powerpc/include/asm/irqflags.h | |||
@@ -32,9 +32,8 @@ | |||
32 | #endif | 32 | #endif |
33 | 33 | ||
34 | /* | 34 | /* |
35 | * Most of the CPU's IRQ-state tracing is done from assembly code; we | 35 | * These are calls to C code, so the caller must be prepared for volatiles to |
36 | * have to call a C function so call a wrapper that saves all the | 36 | * be clobbered. |
37 | * C-clobbered registers. | ||
38 | */ | 37 | */ |
39 | #define TRACE_ENABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_on) | 38 | #define TRACE_ENABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_on) |
40 | #define TRACE_DISABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_off) | 39 | #define TRACE_DISABLE_INTS TRACE_WITH_FRAME_BUFFER(trace_hardirqs_off) |
@@ -42,6 +41,9 @@ | |||
42 | /* | 41 | /* |
43 | * This is used by assembly code to soft-disable interrupts first and | 42 | * This is used by assembly code to soft-disable interrupts first and |
44 | * reconcile irq state. | 43 | * reconcile irq state. |
44 | * | ||
45 | * NB: This may call C code, so the caller must be prepared for volatiles to | ||
46 | * be clobbered. | ||
45 | */ | 47 | */ |
46 | #define RECONCILE_IRQ_STATE(__rA, __rB) \ | 48 | #define RECONCILE_IRQ_STATE(__rA, __rB) \ |
47 | lbz __rA,PACASOFTIRQEN(r13); \ | 49 | lbz __rA,PACASOFTIRQEN(r13); \ |